GitLab

The driver probing does:

test = s5k3l6xx_read(state, S5K3L6XX_REG_MODEL_ID_H);
        if (test.retcode < 0) {
                ret = test.retcode;
                goto err_power;
        } else if (test.value != S5K3L6XX_MODEL_ID_H) {
                dev_err(&c->dev, "model mismatch: 0x%X != 0xC6\n", test.value);
                ret = -EINVAL;
                goto err_power;
        } else
                dev_info(&c->dev, "model high: 0x%X\n", test.value);

So it defines a constant S5K3L6XX_REG_MODEL_ID_H (good) but then doesn't use it the dev_err:

                dev_err(&c->dev, "model mismatch: 0x%X != 0xC6\n", test.value);

why not:

               dev_err(&c->dev, "model mismatch: 0x%X != 0x%X\n", test.value, S5K3L6XX_MODEL_ID_H);

so one doesn't have to check if there's a mismatch between the define and the printf?

Same for S5K3L6XX_REG_MODEL_ID_L and S5K3L6XX_REG_REVISION_NUMBER.

/cc @dorota.czaplejewicz as driver author