Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • L linux
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 135
    • Issues 135
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 26
    • Merge requests 26
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

Due to an influx of spam, we have had to impose restrictions on new accounts. Please see this wiki page for instructions on how to get full permissions. Sorry for the inconvenience.

  • Librem5
  • linux
  • Merge requests
  • !246

CSI additions for testing

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Martin Kepplinger requested to merge martin.kepplinger/linux-next:camera_test into imx8-next-librem5 Nov 05, 2020
  • Overview 62
  • Commits 21
  • Pipelines 7
  • Changes 22

I found that even for testing i2c, it's not enough to have the clocks and power set up (have you seen the same)? I might be wrong here and this is only one idea. Then I looked at power consumption when the both cameras are switched off via the leds and it seems not to add to power consumption, as Angus suspected.

So I think we could add camera stuff but mainline drivers even if they don't work yet. This is enough to have i2c working and the test script could look something like this. You should read 0x00 and 0xde but that doesn't matter. As long as we can read from the devices:

#!/bin/bash
echo 1 | sudo tee /sys/devices/platform/dogwood_leds/leds/camera_pwr/brightness > /dev/null
echo 1 | sudo tee /sys/class/leds/camera_en/brightness > /dev/null
sleep 1
sudo i2cget -f -y 2 0x20 0x00
sudo i2cget -f -y 3 0x10 0x00

This contains the ugly Kconfig hack so that imx7-csi (staging driver) builds; adds the NXP mipi-csi2 driver and enables the devkit camera (that does not work here though). IMO it's still very interesting how that imx7-csi driver evolves upstream and whether the devkit camera starts working at some point without us changing much.

We might need to clean up this patchset a bit but then the driver development branch (more out of tree drivers) becomes a bit smaller when rebased against this.

In short: if we need a test now and i2c indeed doesn't work without csi descriptions/drivers (?), I'd like that approach because we'd have more incentive to fix these parts upstream sooner, like Kconfig and dts, that we probably need to do at some point anyways.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: camera_test