Skip to content
Snippets Groups Projects

Turn off camera after release

Merged Dorota Czaplejewicz requested to merge (removed):debug into pureos/byzantium
All threads resolved!

Fixes https://source.puri.sm/Librem5/linux-next/-/issues/319 , although it might not be the cleanest place to do this.

Merge request reports

Checking pipeline status.

Approval is optional

Merged by Martin KepplingerMartin Kepplinger 3 years ago (May 7, 2021 9:18am UTC)

Merge details

  • Changes merged into pureos/byzantium with 42f20e8d.
  • Deleted the source branch.
  • Auto-merge enabled

Pipeline #67376 passed

Pipeline passed for 42f20e8d on pureos/byzantium

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added camera label

  • Can be tested by switching to the big camera and then crashing Megapixels, and then running it again.

  • I just saw the following after closing megapixels:

    purism@pureos:~$ sudo ./cam_pm.sh 
    ---- hi846 -----
    auto
    suspended
    ---- samsung ---
    auto
    active
    ----------------
        clko2                             2        2        0    25000000          0     0  50000         Y
    purism@pureos:~$ megapixels
    Found config file at /usr/share/megapixels/config/purism,librem5r4.ini
    Adding camera big from config
    Adding camera selfie from config
    Found postprocessor script at /usr/share/megapixels/postprocess.sh
    MPDevice: MEDIA_IOC_SETUP_LINK error 25, Unpassender IOCTL (I/O-Control) für das Gerät
    format 3 47425247
    MPCamera: VIDIOC_S_FMT error 16, Das Gerät oder die Ressource ist belegt
    
    ** (megapixels:4599): CRITICAL **: 08:02:52.043: mp_camera_start_capture: assertion 'camera->has_set_mode' failed
    MPCamera: VIDIOC_DQBUF error 22, Das Argument ist ungültig
    purism@pureos:~$ 

    so the big cam stayed "on". is this what you're referring to here? thanks! I'll test later.

  • Martin Kepplinger resolved all threads

    resolved all threads

  • mentioned in issue #311 (closed)

Please register or sign in to reply
Loading