Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • L linux
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 140
    • Issues 140
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 24
    • Merge requests 24
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Librem5
  • linux
  • Merge requests
  • !465

imx: Fix rounding values

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Dorota Czaplejewicz requested to merge dorota.czaplejewicz/linux-next:formats2 into pureos/byzantium Sep 20, 2021
  • Overview 20
  • Commits 1
  • Pipelines 5
  • Changes 1

The commit message mentions 8-pixels alignment, whereas rounding is performed to 2^8. For the width, the rounding factor is 8-pixels, according to the data sheet. This indicates that the author misunderstood the round_up() semantics in the neighboring roundings too.

This fixes big camera preview in Megapixels:

  1. https://source.puri.sm/dorota.czaplejewicz/nani#debugging-info
  2. sebastian.krzyszkowiak/megapixels@a33e5d21

WIP: this is based on https://source.puri.sm/Librem5/linux-next/-/merge_requests/430 .

Edited Oct 05, 2021 by Dorota Czaplejewicz
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: formats2