Skip to content
Snippets Groups Projects

brcmfmac: introduce module parameter to configure default PM mode

Add module parameter max_pm to allow using PM_MAX as default power management mode. Default PM mode is set to PM_MAX when max_pm=1, and is set to PM_FAST when max_pm=0 or max_pm is not set.

Signed-off-by: Chi-Hsien Lin chi-hsien.lin@cypress.com


Scavenged from Cypress' downstream patches. PM_MAX appears to significantly increase latency, but it may still be worth testing and thinking about how to integrate it in a way that doesn't degrade user experience.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • The change itself looks good at first glance. First: why a module parameter and not a sysfs (or debugfs) interface? how do we intend to use it?

    Secondly, please be prepared to send the change upstream when we merge it here, and if possible do so for the older brcm driver patches too. It doesn't have to finally get merged, but I like mailing list references in MRs. thanks a lot.

Please register or sign in to reply