Skip to content

hack: usb: core: hub: Add a quirk to disable selective suspend of a given port

Sebastian Krzyszkowiak requested to merge sebastian.krzyszkowiak/linux-next:globalsuspend into pureos/byzantium

This can be useful when wanting to rely on global suspend instead for improved wakeup latency and/or reliability.

Kernel's logical devices are still tracking PM status as usual so we know when to suspend the upstream hub.

Special care needs to be taken in order to still support remote wakeup functionality. When the port isn't being actually suspended, we have no idea which port has generated a wakeup request after resuming its hub because there's no change reported in port's status, so we force every port marked with this quirk to be resumed. Also, there's no way for the device to send remote wakeup request while it's not actually suspended, so we need to take care not to logically suspend such devices while a sibling port is active.

This code is likely to break on different USB topologies than the one present on the Librem 5's internal bus, where we want to use this quirk on modem's and hub's upstream ports in order to avoid resets happening when the modem sends remote wakeup request while the hub is being suspended.

Use together with udev rules:

ACTION=="add", SUBSYSTEM=="usb", ENV{ID_PATH}=="platform-xhci-hcd.4.auto-usb-0:0:1.0", ATTR{usb1-port1/quirks}="10000000"
ACTION=="add", SUBSYSTEM=="usb", ENV{ID_PATH}=="platform-xhci-hcd.4.auto-usb-0:1:1.0", ATTR{1-1-port2/quirks}="10000000", ATTR{1-1-port3/power/pm_qos_no_power_off}="0"

Should fix #303 (closed), maybe #197 (closed) too.

Edited by Sebastian Krzyszkowiak

Merge request reports