Skip to content
Snippets Groups Projects

Draft: Honor orientation tag

1 unresolved thread

Draft because I haven't tested it yet.

Also it seems weird to me that each tag is handled manually. Could we not read all the exif data from the DNG/tiff and just carry it over to the jpeg?

Seems a lot less error prone and would avoid all this duplication.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Ok, this is only one part of the puzzle: The actual values saved for the rotation are not right.

    I've taken a couple of pictures rotating the phone 90 more degrees (monitor-sensor picks it up correctly) between each shot, but:

    > $ exiftool IMG202309240919* | grep -i orientation                                                                           
    Orientation                     : Rotate 90 CW
    Orientation                     : Rotate 90 CW
    Orientation                     : Rotate 90 CW
    Orientation                     : Rotate 90 CW
    Orientation                     : Rotate 90 CW
    Orientation                     : Rotate 90 CW
    Orientation                     : Rotate 90 CW
    Orientation                     : Rotate 90 CW
    

    the data is already wrong in the DNG.

    • The actual values saved for the rotation are not right.

      They are right, in a sense that they describe the orientation of the sensor in relation to the natural orientation of the whole device. Millipixels does not read anything from iio-sensor-proxy, that's the part that needs to be implemented.

      IIRC the orientation gets already applied to the image data when developing it into JPEG, so if I'm right it's already honored there. Saving it again into JPEG's EXIF will make it be applied twice.

      Could we not read all the exif data from the DNG/tiff and just carry it over to the jpeg?

      Most of DNG's tags do not make sense in the context of JPEG.

      Edited by Sebastian Krzyszkowiak
    • They are right, in a sense that they describe the orientation of the sensor in relation to the natural orientation of the whole device.

      Ah, but having that as the orientation tag does not seem very informative to me ;) Also: I just read where the rotation is set (it comes from the config files, right?), so I have some better idea what's going on now

      Ok, so I have to basically apply the rotation reported by iio-sensor-proxy on top. Got it!

      I'm going for the most straight forward (i.e. hacky solution and just put it into process_pipeline.c

      Thanks for the pointers!

    • iio-sensor proxy will work as a start but we might want to take that information from phoc at a later point as the devices natural orientation might not match what iio-sensor-proxy assumes because the panel also has transform via drm properties.

      This isn't an issue on the L5, just wanted to mention it that it might make sense to structure the code in a way that makes it simple to switch to another DBus interface at some point.

    • Please register or sign in to reply
Please register or sign in to reply
Loading