Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
  • Sign in / Register
phosh
phosh
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 151
    • Issues 151
    • List
    • Boards
    • Labels
    • Milestones
  • Merge Requests 23
    • Merge Requests 23
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Librem5
  • phoshphosh
  • Merge Requests
  • !373

Merged
Opened Oct 26, 2019 by Sebastian Krzyszkowiak@sebastian.krzyszkowiak
  • Report abuse
Report abuse

activity: Handle apps with "gnome-" prefix in their app ID

  • Overview 3
  • Commits 1
  • Pipelines 3
  • Changes 1

Otherwise we end up with "org.gnome.Gnome-software" kind of names.

This fixes missing icons in activity switcher for at least GNOME Calendar and GNOME Software.

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch "https://source.puri.sm/sebastian.krzyszkowiak/phosh.git" "activity-gnome-prefix"
git checkout -b "sebastian.krzyszkowiak/phosh-activity-gnome-prefix" FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout "origin/master"
git merge --no-ff "sebastian.krzyszkowiak/phosh-activity-gnome-prefix"

Step 4. Push the result of the merge to GitLab

git push origin "master"

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
0
Labels
None
Assign labels
  • View project labels
Reference: Librem5/phosh!373