Skip to content
Snippets Groups Projects

Don't recreate backgrounds all the time

Merged Guido Gunther requested to merge guido.gunther/phosh:background-configure into master

Based on @marty1885 's work in !531 (merged) i removed the recreating of backgrounds by listening to PhoshMonitor::configured and PhoshShell::notify::primary-monitor. This also includes the suggested cleanup of PhoshBackground as suggested by @sebastian.krzyszkowiak in !531 (merged). Since we wait for the final configure i don't think we need !541 (closed).

This way we make sure PhoshBackground only needs minimal knowledge about what's going on with PhoshMonitor and ideally we remove the phosh_shell_get_usable_area () at one point as well so this class an focus on rendering the background.

Closes: #325 (closed)

Edited by Guido Gunther

Merge request reports

Pipeline #56855 passed

Pipeline passed for 7c30e37b on guido.gunther:background-configure

Test coverage 14.40% (0.00%) from 1 job
Approval is optional

Merged by Sebastian KrzyszkowiakSebastian Krzyszkowiak 4 years ago (Jun 30, 2020 4:12pm UTC)

Merge details

Pipeline #56858 failed

Pipeline failed for 7c30e37b on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading