• Marek Vasut's avatar
    sf: Correct data types in stm_is_locked_sr() · ea9619ae
    Marek Vasut authored
    The stm_is_locked_sr() function is picked from Linux kernel. For reason
    unknown, the 64bit data types used by the function and present in Linux
    were replaced with 32bit unsigned ones, which causes trouble.
    The testcase performed was done using ST M25P80 chip.
    The command used was:
     => sf protect unlock 0 0x10000
    The call chain starts in stm_unlock(), which calls stm_is_locked_sr()
    with negative ofs argument. This works fine in Linux, where the "ofs"
    is loff_t, which is signed long long, while this fails in U-Boot, where
    "ofs" is u32 (unsigned int). Because of this signedness problem, the
    expression past the return statement to be incorrectly evaluated to 1,
    which in turn propagates back to stm_unlock() and results in -EINVAL.
    The correction is very simple, just use the correctly sized data types
    with correct signedness in the function to make it work as intended.
    Signed-off-by: default avatarMarek Vasut <marex@denx.de>
    Cc: Simon Glass <sjg@chromium.org>
    Reviewed-by: default avatarJagan Teki <jteki@openedev.com>
spi_flash.c 26.5 KB