Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • V virtboard
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 11
    • Issues 11
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

Due to an influx of spam, we have had to impose restrictions on new accounts. Please see this wiki page for instructions on how to get full permissions. Sorry for the inconvenience.

  • Librem5
  • virtboard
  • Merge requests
  • !28

Fix crashes when pressing tab

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Dorota Czaplejewicz requested to merge fix_keyboard_away into master Dec 10, 2018
  • Overview 0
  • Commits 3
  • Pipelines 1
  • Changes 2

EDIT: I decided to combine the 3 MRs:

Fix crash when the window disappears

The redraw procedure was allowed to run after a window was destroyed


Don't let dead widgets be clicked

Fixes crash when a widget would be free'd but a click event would still try to access it.


Keep keyboard visible when buttons are pressed

This fixes momentary clicks which hide the keyboard, causing the button press never to be released.

It's still possible to get keys stuck by drag-and-dropping away from the original key.

Addresses the root cause of #18 (closed)

Edited Dec 11, 2018 by Dorota Czaplejewicz
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: fix_keyboard_away