- Dec 14, 2017
-
-
Debarshi Ray authored
-
Debarshi Ray authored
-
- Dec 13, 2017
-
-
Stas Solovey authored
(cherry picked from commit 494abfc0)
-
- Dec 08, 2017
-
-
Sveinn í Felli authored
(cherry picked from commit 2c5ba2d6)
-
- Dec 06, 2017
-
-
Kukuh Syafaat authored
-
- Dec 05, 2017
-
-
Debarshi Ray authored
-
Debarshi Ray authored
-
Debarshi Ray authored
The current GObject recommendation is to use the generated get_instance_private function instead of a separate priv pointer in the instance struct. This saves one pointer per class in the hierarchy multiplied by the number of instances of the type, and the function is fast enough because it only does pointer arithmetic.
-
Debarshi Ray authored
This paves the way for improving our GObject use and reducing the amount of boilerplate.
-
Debarshi Ray authored
-
Debarshi Ray authored
-
Debarshi Ray authored
Having the GAsyncReadyCallback directly call g_task_propagate_boolean on the passed in GAsyncResult leads to less code. However, the lack of a _finish function makes it slightly more difficult to follow the logic through a maze of similarly named functions. Plus, it doesn't hurt to have some extra assertions and be consistent with the general pattern of asynchronous operations in GIO.
-
Debarshi Ray authored
This will make the subsequent commit easier to read.
-
Debarshi Ray authored
Since the caller might not pass a GCancellable, it's no longer possible to rely on g_task_return_error_if_cancelled to return G_IO_ERROR_CANCELLED.
-
Debarshi Ray authored
-
Debarshi Ray authored
Don't use a separate line to initialize variables.
-
Kukuh Syafaat authored
-
- Nov 28, 2017
-
-
Борисав Живановић authored
-
- Nov 27, 2017
-
-
Yosef Or Boczko authored
-
- Nov 25, 2017
-
-
Aurimas Černius authored
-
- Nov 20, 2017
-
-
Debarshi Ray authored
Bump minimum WebKitGTK+ version to 2.12.0.
-
Debarshi Ray authored
Historically, Flickr has never returned an error code when the user denied access to an account. That meant trying to parse the DOM and detect the click on the appropriate UI element. Except, the "click" event handler was never invoked. This might have been a WebKit bug, but it was never diagnosed. See commit 947b7729. This has gotten worse recently because attempting to inspect the UI element breaks the WebKit inspector. There is now a workaround in place based on having the same callback URI as the one listed as GNOME's website in Flickr's App Garden. See commit 7f1cb7e1. Long story short, the is_deny_node code has never been used. It is time to remove it.
-
Debarshi Ray authored
-
- Nov 17, 2017
-
-
Milo Casagrande authored
(cherry picked from commit ecb82033)
-
- Nov 15, 2017
-
-
Muhammet Kara authored
(cherry picked from commit 0bc0bcd3)
-
- Nov 13, 2017
-
-
Tim Sabsch authored
-
Daniel Mustieles authored
-
- Nov 11, 2017
-
-
Rafael Fontenelle authored
(cherry picked from commit 3240b295)
-
- Nov 10, 2017
-
-
Pawan Chitrakar authored
(cherry picked from commit 30176c71)
-
- Nov 09, 2017
-
-
Kjartan Maraas authored
-
gogo authored
-
- Nov 08, 2017
-
-
Marek Cernocky authored
-
- Nov 07, 2017
-
-
Dušan Kazik authored
(cherry picked from commit 4504e543)
-
Piotr Drąg authored
-
Debarshi Ray authored
So far, realmd was being merely used to auto-discover a list of realms, and validate whether the user entered a valid realm or not before prompting for credentials. This sounds nice in theory but, in practice, it is far too fragile. For example, realmd gets frequently tripped up by Fedora's Kerberos setup which uses _kerberos._tcp instead of the more common _kerberos._udp SRV record. Secondly, the realm validation isn't snappy and can take a while, so the user has to wait a bit before she is able to enter her credentials. The current UI is also odd because it presents separate fields for entering the realm and the username. Most people are used to entering username@realm or username@REALM because of their familiarity with email addresses and kinit. Therefore, the account addition UI has now been re-written without realmd. There is only one field for the user to enter her principal, and the realm is automatically capitalized if it isn't. It entirely relies on libkrb5.so to validate the principal during the initial sign-in once the credentials have been entered. https://bugzilla.gnome.org/show_bug.cgi?id=789187
-
-
Debarshi Ray authored
-
Debarshi Ray authored
-
Fabio Tomat authored
-
Pawan Chitrakar authored
(cherry picked from commit 8ab60fda)
-