- Feb 09, 2019
-
-
Debarshi Ray authored
-
- Jan 31, 2019
-
-
Debarshi Ray authored
-
Neil McGovern authored
Currently, a lot of personal information was being received, including gender and profile picture. The email is the only thing that's really used, for the account's identity and presentation identy, and the rest was being simply thrown away. Therefore, avoid receiving them in the first place. Verified via the Google APIs Explorer and the Google OAuth 2.0 Playground: https://developers.google.com/apis-explorer/#p/oauth2/v2/oauth2.userinfo.get https://developers.google.com/oauthplayground/ https://gitlab.gnome.org/GNOME/gnome-online-accounts/merge_requests/19
-
- Jan 30, 2019
-
-
Ryuta Fujii authored
-
Ryuta Fujii authored
-
- Jan 20, 2019
-
-
Pieter Schalk Schoeman authored
-
- Jan 17, 2019
-
-
Charles Monzat authored
(cherry picked from commit e1157fab)
-
- Jan 09, 2019
-
-
Jan Alexander Steffens (heftig) authored
A read(2) from the timerfd will fail with ECANCELED [1], which will be seen as G_IO_ERROR_CANCELLED, when the clock jumps after waking up. In this case, instead of giving up, the alarm should continue to fire or re-arm as needed. [1] http://man7.org/linux/man-pages/man2/timerfd_create.2.html https://bugzilla.gnome.org/show_bug.cgi?id=796095
-
- Dec 16, 2018
-
-
Yacine Bouklif authored
-
- Dec 12, 2018
-
-
Debarshi Ray authored
-
-
- Dec 05, 2018
-
-
Debarshi Ray authored
-
Debarshi Ray authored
-
Debarshi Ray authored
-
- Nov 28, 2018
-
-
Carmen Bianca BAKKER authored
(cherry picked from commit 2bc35ff2)
-
- Nov 27, 2018
-
-
Debarshi Ray authored
-
Debarshi Ray authored
-
Debarshi Ray authored
-
Debarshi Ray authored
A GCancellable can be cancelled from a different thread than the one where the GTask for the goa_http_client_check operation was created. Since the GCancellable::cancelled handler is invoked in the same thread as the g_cancellable_cancel call, unguarded access to the GError in CheckData is unsafe. Instead of introducing a GMutex, the GError can be set in the response callback which is guaranteed to be invoked in the same thread where the GTask was created. Ensuring that the GError is always accessed from the same thread makes it considerably easier to reason about its state. eg., it can be guaranteed that it won't be set if the status of the response isn't SOUP_STATUS_CANCELLED.
-
Debarshi Ray authored
The synchronous variant of goa_http_client_check runs a thread-specific GMainContext until the asynchronous variant invokes its callback. Once the callback is invoked, the GMainLoop is quit. This means that there won't be any further iterations of the loop and no new GSources will be dispatched. Therefore, when the synchronous HttpClient gets aborted by the GCancellable or due to an SSL error, then the following http_client_check_response_cb might not be invoked due to the lack of a running GMainLoop to drive the GMainContext; as a result, the GTask will get leaked. Solve this by tracking the GError and returning the GTask only when everything is complete. This was fixed in commit 3b35bd71, but broke in commit 73242fa2 when porting to GTask. https://bugzilla.gnome.org/show_bug.cgi?id=764157
-
Debarshi Ray authored
Now that the deprecated SoupSessionAsync has been replaced with SoupSession [1], the response callbacks are invoked in the next iteration of the main loop after soup_session_abort has returned. This means that ews_client_autodiscover_response_cb is no longer called from a GCancellable::cancelled signal handler. Therefore, it's safe to directly disconnect from the GCancellable in the response callback without fearing for any deadlocks. This reverts commit 07f13b1d. [1] Commit 6c3e3c2d https://bugzilla.gnome.org/show_bug.cgi?id=764157
-
Debarshi Ray authored
Now that the deprecated SoupSessionAsync has been replaced with SoupSession [1], the response callbacks are invoked in the next iteration of the main loop after soup_session_abort has returned. This means that http_client_check_response_cb is no longer called from a GCancellable::cancelled signal handler. Therefore, it's safe to directly disconnect from the GCancellable in the response callback without fearing for any deadlocks. This reverts commit b2f94098. [1] Commit 6c3e3c2d https://bugzilla.gnome.org/show_bug.cgi?id=764157
-
- Nov 26, 2018
-
-
Andrea Veri authored
-
Andrea Veri authored
-
- Nov 23, 2018
-
-
Debarshi Ray authored
-
Debarshi Ray authored
-
Debarshi Ray authored
During the GNOME 3.25.x / 3.26 development cycle it was decided that Todoist doesn't fit the goals of GNOME Online Accounts [1]. The two applications that were meant to consume the Todoist provider, GNOME Recipes [2] and To Do [3], are not part of a minimum viable GNOME system. While they do bear the GNOME name and follow the GNOME Human Interface Guidelines [4], they are not tightly coupled with the rest of GNOME. eg., they don't follow the GNOME development and release schedule. They are optional applications which often won't be installed, and we don't want to have online accounts that don't do anything. Since then, Recipes has grown its own built-in Todoist support, and To Do is expected to do the same. [1] https://wiki.gnome.org/Projects/GnomeOnlineAccounts/Goals [2] https://wiki.gnome.org/Apps/Recipes [3] https://wiki.gnome.org/Apps/Todo [4] https://developer.gnome.org/hig/stable/
-
- Oct 28, 2018
-
-
Anish Sheela authored
(cherry picked from commit a21c5362)
-
- Oct 16, 2018
-
-
Kristjan SCHMIDT authored
-
- Oct 03, 2018
-
-
Debarshi Ray authored
These two pre-processor macros have existed since the first commit, but it isn't clear why. They were used with the Settings panel while it lived in gnome-online-accounts.git, but were dropped when it was moved to gnome-control-center.git [1], again, it isn't clear why. The _POSIX_PTHREAD_SEMANTICS documentation [2] says that it will "enable threading extensions on Solaris", and is covered under the AC_USE_SYSTEM_EXTENSIONS banner. The code in gnome-online-accounts.git uses threads, but does so via the GLib and GIO APIs, and doesn't use the POSIX threads (or pthreads) API directly. GLib itself defines it as part of AC_USE_SYSTEM_EXTENSIONS in its Autotools build [3] but not in the Meson build. The Meson build does define other AC_USE_SYSTEM_EXTENSIONS components, but not _POSIX_PTHREAD_SEMANTICS. Therefore, it seems safe to conclude that the _POSIX_PTHREAD_SEMANTICS doesn't serve any purpose here in gnome-online-accounts.git. The _REENTRANT documentation [4] says that it's obsolete. GLib defines it on Solaris and Mac OS X in its Autotools build, but that's solely for the Oracle compilers on Solaris and possibly other historical reasons. Both GCC and Clang appear to expand -pthread to define _REENTRANT on their own [5]. Since Meson doesn't support the Oracle compiler, it's not present in GLib's Meson build at all [6]. Given the current momentum towards Meson in GNOME, and that Meson doesn't support it, it's safe to ignore anything specific to the Oracle compiler. Hence _REENTRANT can be removed. [1] https://bugzilla.gnome.org/show_bug.cgi?id=653334 https://bugzilla.gnome.org/show_bug.cgi?id=653335 [2] https://www.gnu.org/software/autoconf/manual/autoconf-2.64/html_node/Posix-Variants.html [3] https://bugzilla.gnome.org/show_bug.cgi?id=684123 [4] https://www.gnu.org/software/libc/manual/html_node/Feature-Test-Macros.html [5] https://stackoverflow.com/questions/875789/do-i-need-d-reentrant-with-pthreads https://github.com/mesonbuild/meson/issues/3810 [6] https://gitlab.gnome.org/GNOME/glib/issues/1432 https://gitlab.gnome.org/GNOME/gnome-online-accounts/merge_requests/14
-
- Oct 01, 2018
-
-
Debarshi Ray authored
Fallout from d46cd37f
-
- Sep 05, 2018
-
-
Yuras Shumovich authored
(cherry picked from commit c1fa585b)
-
- Sep 01, 2018
-
-
Madis O authored
-
Debarshi Ray authored
-
Debarshi Ray authored
-
- Aug 20, 2018
-
-
Khaled Hosny authored
-
- Aug 16, 2018
-
-
Debarshi Ray authored
-
Debarshi Ray authored
-