Skip to content
  • Horia Geantă's avatar
    crypto: caam/qi - fix IV DMA mapping and updating · 3a488aae
    Horia Geantă authored
    There are two IV-related issues:
    (1) crypto API does not guarantee to provide an IV buffer that is DMAable,
    thus it's incorrect to DMA map it
    (2) for in-place decryption, since ciphertext is overwritten with
    plaintext, updated IV (req->info) will contain the last block of plaintext
    (instead of the last block of ciphertext)
    
    While these two issues could be fixed separately, it's straightforward
    to fix both in the same time - by using the {ablkcipher,aead}_edesc
    extended descriptor to store the IV that will be fed to the crypto engine;
    this allows for fixing (2) by saving req->src[last_block] in req->info
    directly, i.e. without allocating yet another temporary buffer.
    
    A side effect of the fix is that it's no longer possible to have the IV
    contiguous with req->src or req->dst.
    Code checking for this case is removed.
    
    Cc: <stable@vger.kernel.org> # 4.14+
    Fixes: a68a1938 ("crypto: caam/qi - properly set IV after {en,de}crypt")
    Link: http://lkml.kernel.org/r/20170113084620.GF22022@gondor.apana.org.au
    
    
    Reported-by: default avatarGilad Ben-Yossef <gilad@benyossef.com>
    Signed-off-by: default avatarHoria Geantă <horia.geanta@nxp.com>
    Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
    3a488aae