Skip to content
  • Miklos Szeredi's avatar
    fix execute checking in permission() · 22590e41
    Miklos Szeredi authored
    
    
    permission() checks that MAY_EXEC is only allowed on regular files if at least
    one execute bit is set in the file mode.
    
    generic_permission() already ensures this, so the extra check in permission()
    is superfluous.
    
    If the filesystem defines it's own ->permission() the check may still be
    needed.  In this case move it after ->permission().  This is needed because
    filesystems such as FUSE may need to refresh the inode attributes before
    checking permissions.
    
    This check should be moved inside ->permission(), but that's another story.
    
    Signed-off-by: default avatarMiklos Szeredi <mszeredi@suse.cz>
    Cc: Al Viro <viro@zeniv.linux.org.uk>
    Cc: Christoph Hellwig <hch@lst.de>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    22590e41