Skip to content
  • Takashi Iwai's avatar
    Revert "ALSA: hda - Allow power_save_controller option override DCAPS" · 8fc24426
    Takashi Iwai authored
    This reverts commit 6ab31741.
    
    The commit [6ab31741: ALSA: hda - Allow power_save_controller option
    override DCAPS] changed the behavior of power_save_controller so that
    it can override the driver capability.  This assumed that this option
    is rarely changed dynamically unlike power_save option.  Too naive.
    
    It turned out that the user-space power-management tool tries to set
    power_save_controller option to 1 together with power_save option
    without knowing what's actually doing.  This enabled forcibly the
    runtime PM of the controller,  which is known to be broken om many
    chips thus disabled as default.
    
    So, the only sane fix is to revert this commit again.  It was intended
    to ease debugging/testing for runtime PM enablement, but obviously we
    need another way for it.
    
    Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=56171
    
    
    Reported-and-tested-by: default avatarNikita Tsukanov <keks9n@gmail.com>
    Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
    8fc24426