• Danesh Petigara's avatar
    mm: cma: fix CMA aligned offset calculation · 850fc430
    Danesh Petigara authored
    The CMA aligned offset calculation is incorrect for non-zero order_per_bit
    values.
    
    For example, if cma->order_per_bit=1, cma->base_pfn= 0x2f800000 and
    align_order=12, the function returns a value of 0x17c00 instead of 0x400.
    
    This patch fixes the CMA aligned offset calculation.
    
    The previous calculation was wrong and would return too-large values for
    the offset, so that when cma_alloc looks for free pages in the bitmap with
    the requested alignment > order_per_bit, it starts too far into the bitmap
    and so CMA allocations will fail despite there actually being plenty of
    free pages remaining.  It will also probably have the wrong alignment.
    With this change, we will get the correct offset into the bitmap.
    
    One affected user is powerpc KVM, which has kvm_cma->order_per_bit set to
    KVM_CMA_CHUNK_ORDER - PAGE_SHIFT, or 18 - 12 = 6.
    
    [gregory.0xf0@gmail.com: changelog additions]
    Signed-off-by: 's avatarDanesh Petigara <dpetigara@broadcom.com>
    Reviewed-by: 's avatarGregory Fong <gregory.0xf0@gmail.com>
    Acked-by: 's avatarMichal Nazarewicz <mina86@mina86.com>
    Cc: <stable@vger.kernel.org>
    Signed-off-by: 's avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: 's avatarLinus Torvalds <torvalds@linux-foundation.org>
    850fc430
cma.c 12 KB