• Arnaldo Carvalho de Melo's avatar
    perf session: Make events_stats u64 to avoid overflow on 32-bit arches · b5b60fda
    Arnaldo Carvalho de Melo authored
    Pekka Enberg reported weird percentages in perf report. It
    turns out we are overflowing a 32-bit variables in struct
    events_stats on 32-bit architectures.
    
    Before:
    
     [acme@ana linux-2.6-tip]$ perf report -i pekka.perf.data 2> /dev/null | head -10
       281.96%       Xorg                        b710a561  [.] 0x000000b710a561
       140.15%       Xorg  [kernel]                        [k] __initramfs_end
        51.56%   metacity  libgobject-2.0.so.0.2000.1      [.] 0x00000000026e46
        35.12%  evolution  libcairo.so.2.10800.6           [.] 0x000000000203bd
        33.84%   metacity  libpthread-2.9.so               [.] 0x00000000007a3d
    
    After:
    
     [acme@ana linux-2.6-tip]$ perf report -i pekka.perf.data 2> /dev/null | head -10
        30.04%       Xorg                       b710a561   [.] 0x000000b710a561
        14.93%       Xorg  [kernel]                        [k] __initramfs_end
         5.49%   metacity  libgobject-2.0.so.0.2000.1      [.] 0x00000000026e46
         3.74%  evolution  libcairo.so.2.10800.6           [.] 0x000000000203bd
         3.61%   metacity  libpthread-2.9.so               [.] 0x00000000007a3d
    Reported-by: default avatarPekka Enberg <penberg@cs.helsinki.fi>
    Tested-by: default avatarPekka Enberg <penberg@cs.helsinki.fi>
    Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    Cc: Frederic Weisbecker <fweisbec@gmail.com>
    Cc: Mike Galbraith <efault@gmx.de>
    Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Cc: Paul Mackerras <paulus@samba.org>
    LKML-Reference: <1261148583-20395-1-git-send-email-acme@infradead.org>
    Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
    b5b60fda
Name
Last commit
Last update
..
Documentation Loading commit data...
bench Loading commit data...
scripts/perl Loading commit data...
util Loading commit data...
.gitignore Loading commit data...
CREDITS Loading commit data...
Makefile Loading commit data...
builtin-annotate.c Loading commit data...
builtin-bench.c Loading commit data...
builtin-buildid-list.c Loading commit data...
builtin-diff.c Loading commit data...
builtin-help.c Loading commit data...
builtin-kmem.c Loading commit data...
builtin-list.c Loading commit data...
builtin-probe.c Loading commit data...
builtin-record.c Loading commit data...
builtin-report.c Loading commit data...
builtin-sched.c Loading commit data...
builtin-stat.c Loading commit data...
builtin-timechart.c Loading commit data...
builtin-top.c Loading commit data...
builtin-trace.c Loading commit data...
builtin.h Loading commit data...
command-list.txt Loading commit data...
design.txt Loading commit data...
perf.c Loading commit data...
perf.h Loading commit data...