• Randy Dunlap's avatar
    arc: [plat-eznps] fix printk warning in arc/plat-eznps/mtm.c · 9e2ea405
    Randy Dunlap authored
    Fix printk format warning in arch/arc/plat-eznps/mtm.c:
    
    In file included from ../include/linux/printk.h:7,
                     from ../include/linux/kernel.h:14,
                     from ../include/linux/list.h:9,
                     from ../include/linux/smp.h:12,
                     from ../arch/arc/plat-eznps/mtm.c:17:
    ../arch/arc/plat-eznps/mtm.c: In function 'set_mtm_hs_ctr':
    ../include/linux/kern_levels.h:5:18: warning: format '%d' expects argument of type 'int', but argument 2 has type 'long int' [-Wformat=]
     #define KERN_SOH "\001"  /* ASCII Start Of Header */
                      ^~~~~~
    ../include/linux/kern_levels.h:11:18: note: in expansion of macro 'KERN_SOH'
     #define KERN_ERR KERN_SOH "3" /* error conditions */
                      ^~~~~~~~
    ../include/linux/printk.h:308:9: note: in expansion of macro 'KERN_ERR'
      printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
             ^~~~~~~~
    ../arch/arc/plat-eznps/mtm.c:166:3: note: in expansion of macro 'pr_err'
       pr_err("** Invalid @nps_mtm_hs_ctr [%d] needs to be [%d:%d] (incl)\n",
       ^~~~~~
    ../arch/arc/plat-eznps/mtm.c:166:40: note: format string is defined here
       pr_err("** Invalid @nps_mtm_hs_ctr [%d] needs to be [%d:%d] (incl)\n",
                                           ~^
                                           %ld
    The hs_ctr variable can just be int instead of long, so also change
    kstrtol() to kstrtoint() and leave the format string as %d.
    
    Also add 2 header files since they are used in mtm.c and we prefer
    not to depend on accidental/indirect #includes.
    
    Cc: linux-snps-arc@lists.infradead.org
    Cc: Ofer Levi <oferle@mellanox.com>
    Reviewed-by: default avatarLeon Romanovsky <leonro@mellanox.com>
    Signed-off-by: default avatarRandy Dunlap <rdunlap@infradead.org>
    Signed-off-by: default avatarVineet Gupta <vgupta@synopsys.com>
    9e2ea405
Name
Last commit
Last update
..
include/plat Loading commit data...
Kconfig Loading commit data...
Makefile Loading commit data...
ctop.c Loading commit data...
entry.S Loading commit data...
mtm.c Loading commit data...
platform.c Loading commit data...
smp.c Loading commit data...