Mohammed Sadiq authored 4 years ago and Mohammed Sadiq committed 4 years ago

Move Purple API to delete a chat to chatty-chat use that API
to delete a chat.

Mohammed Sadiq authored 4 years ago and Mohammed Sadiq committed 4 years ago

We were always passing NULL as db

Mohammed Sadiq authored 4 years ago and Mohammed Sadiq committed 4 years ago

history is a singleton object.  It's created and finalized only once in
an application's lifetime.  But in tests, the same object may be reused
after closing database, which can result in races that lock the GTask to
never complete.

Free object data in dispose and explicitly run dispose when the database
is closed so that we don't have wait for GObject to free data which may
be delayed.

When the window style changes from folded mode to non-folded mode,
the first chat list item is selected by default regardless of the
current state.

Instead of blindly selecting the first item, select the first item
only if none is selected when window changes to non-folded mode.

Currently, the count is reset only when switching the chat page.
But if the previously selected chat is the same as the currently
selected one, the count isn't reset (as no switching happened)

Fixes #387

Zander Brown authored 4 years ago and Mohammed Sadiq committed 4 years ago

This is the same change we made in phosh

Librem5/phosh@482b35a7

purple_conversation_present() does all what we need, use that.
Don't repeat them.

This will help us dissociate libpurple handling UI and isolate
UI code from program logic.

items-changed signal is emitted after the item is removed from the list.
If the removed item is selected_item, it may have already freed.  So the
CHATTY_IS_CHAT (selected_item) is invoking a UB.  Let's fix it.

Don’t duplicate the same code everywhere

Use the current active window instead of placing on top of the main window.
The main window is not always required to be the active one.  Also avoid
the cast as the window may be NULL if no window is present

Mohammed Sadiq authored 4 years ago and Mohammed Sadiq committed 4 years ago

This code is never run

We eventually want to remove this variable so that ui_data can
be reused for saving associated GObject

Do it in chat-view instead of manager, so that we can avoid
a public API

So that we can update chat-view widgets based on the property
instead of letting other classes do it.

Let's focus the entry when mapped and so we don't have to handle
this outside of chat-view.

Fixes lintian warning desktop-entry-lacks-main-category

Fixes lintian information: spelling-error-in-binary

Fixes #244