Skip to content
Snippets Groups Projects
  1. Oct 07, 2005
    • Matthias Clasen's avatar
      fix includes · 6592f00a
      Matthias Clasen authored
      6592f00a
    • Federico Mena Quintero's avatar
      Fixes bug #317999: · cca93029
      Federico Mena Quintero authored
      2005-10-07  Federico Mena Quintero  <federico@ximian.com>
      
      	Fixes bug #317999:
      
      	* tests/autotestfilechooser.c (test_reload_sequence): Ensure that
      	the the result of gtk_file_chooser_get_folder() is NULL or
      	non-NULL at the right times.  Log the tests.
      	(test_button_folder_states): New test for the initial states of
      	the current folder in GtkFileChooserButton.
      	(main): Test that the number of warnings/errors/critical errors is
      	zero.
      
      	* gtk/gtkfilechooser.c (gtk_file_chooser_get_current_folder):
      	Clarify the documentation on when this can return NULL.
      	(gtk_file_chooser_get_current_folder_uri): Likewise.
      
      	* gtk/gtkfilechooserbutton.c (struct
      	_GtkFileChooserButtonPrivate): Added a folder_has_been_set flag;
      	we use it to keep track of whether a folder has been set.
      	(gtk_file_chooser_button_map):  Implement.  If no folder has been
      	loaded before, we at least try to load $cwd here.
      	(gtk_file_chooser_button_constructor): If the construct-time
      	dialog already has a folder set, turn on our folder_has_been_set
      	flag.
      	(dialog_current_folder_changed_cb): Turn on our
      	folder_has_been_set flag.
      cca93029
    • Michael Natterer's avatar
      remove some explicit #defines of PROFILE_FILE_CHOOSER because they break · cab26ded
      Michael Natterer authored
      2005-10-07  Michael Natterer  <mitch@gimp.org>
      
      	* gtk/gtkfilechooserdefault.c: remove some explicit #defines of
      	PROFILE_FILE_CHOOSER because they break compilation after the
      	removal of <unistd.h>.
      cab26ded
    • Matthias Clasen's avatar
      Remove a redundant (and unconditional) include of unistd.h (#318211, · 5b2d546e
      Matthias Clasen authored
      2005-10-07   Matthias Clasen  <mclasen@redhat.com>
      
              * gtk/gtkfilechooserdefault.c: Remove a redundant (and
              unconditional) include of unistd.h  (#318211, Kazuki Iwamoto)
      5b2d546e
    • Matthias Clasen's avatar
      Use g_return_val_if_fail(), not g_return_if_fail(). (#318412, Kazuki · 8725724e
      Matthias Clasen authored
      2005-10-07   Matthias Clasen  <mclasen@redhat.com>
      
              * gtk/gtktexttag.c (gtk_text_attributes_ref): Use
              g_return_val_if_fail(), not g_return_if_fail().  (#318412,
              Kazuki Iwamoto)
      8725724e
    • Matthias Clasen's avatar
      Add a has-selection property · b863d240
      Matthias Clasen authored
      b863d240
  2. Oct 05, 2005
  3. Oct 04, 2005
  4. Oct 03, 2005
  5. Sep 30, 2005
    • Tor Lillqvist's avatar
      In case BitBlt() fails with ERROR_INVALID_HANDLE, the most probable cause · ef2c2326
      Tor Lillqvist authored
      2005-10-01  Tor Lillqvist  <tml@novell.com>
      
      	* gdk/win32/gdkdrawable-win32.c (blit_from_pixmap): In case
      	BitBlt() fails with ERROR_INVALID_HANDLE, the most probable cause
      	is that the the desktop isn't visible because the session has been
      	switched, the screen is locked, or a terminal server session
      	disconnected, so no error message necessary. (#137796)
      
      	It is of course remotely possible that BitBlt() failing with
      	ERROR_INVALID_HANDLE might also be caused by some other
      	problem. We could strive for perfection and track whether the
      	desktop is visible by using WTSRegisterSessionNotification() and
      	handling WM_WTSESSION_CHANGE. I think that's overdoing it just for
      	this issue, though. If we would track desktop visibility, we
      	should then avoid even trying to update the display at all while
      	the desktop isn't visible.
      ef2c2326
    • Adam Weinberger's avatar
      Updated Canadian English translation. · 1319ffec
      Adam Weinberger authored
      2005-09-30  Adam Weinberger  <adamw@gnome.org>
      
      	* en_CA.po: Updated Canadian English translation.
      1319ffec
    • Matthias Clasen's avatar
      Another attempt to correct the calculations for the first week day. We may · c693b5d6
      Matthias Clasen authored
      2005-09-30  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtkcalendar.c (gtk_calendar_init): Another attempt
      	to correct the calculations for the first week day. We may
      	just have to remove this code if too many locales turn out
      	to have broken data.
      c693b5d6
    • Matthias Clasen's avatar
      Don't leak pixbuf in some cases. (#317611, Tommi Komulainen) · 0d047a35
      Matthias Clasen authored
      2005-09-30  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtkimage.c (gtk_image_expose): Don't leak pixbuf in
      	some cases.  (#317611, Tommi Komulainen)
      0d047a35
    • Matthias Clasen's avatar
      Prevent overflow when storing size hints in an unsigned short variable. · 51c6eb96
      Matthias Clasen authored
      2005-09-30  Matthias Clasen  <mclasen@redhat.com>
      
              * gtk/gtksocket-x11.c (_gtk_socket_windowing_size_request):
              Prevent overflow when storing size hints in an unsigned
              short variable. Tracked down by Ray Strode and Søren Sandmann.
      51c6eb96
  6. Sep 29, 2005
    • Matthias Clasen's avatar
      Check arguments. (#317491, Paolo Borelli) · 56b4314a
      Matthias Clasen authored
      2005-09-29  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtkbutton.c (gtk_button_set_image): Check arguments.  (#317491,
      	Paolo Borelli)
      56b4314a
    • Matthias Clasen's avatar
      Stop drags when being grab shadowed. (#317332) · f6501cb4
      Matthias Clasen authored
      2005-09-29  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtkpaned.c (gtk_paned_grab_notify): Stop drags when being
      	grab shadowed.  (#317332)
      f6501cb4
    • Tor Lillqvist's avatar
      DLLs are always in bin nowadays, no need to test. · 840796df
      Tor Lillqvist authored
      2005-09-29  Tor Lillqvist  <tml@novell.com>
      
      	* gtk-zip.sh.in: DLLs are always in bin nowadays, no need to test.
      840796df
    • Federico Mena Quintero's avatar
      Oops, return if the unmap test fails. (test_reload_sequence): Use · e14ad12b
      Federico Mena Quintero authored
      2005-09-28  Federico Mena Quintero  <federico@ximian.com>
      
      	* tests/autotestfilechooser.c (test_reload_sequence): Oops, return
      	if the unmap test fails.
      	(test_reload_sequence): Use gtk_widget_show_now() instead of
      	gtk_widget_show() for the dialog.
      	Thanks to Tim Janik for noticing these.
      e14ad12b
    • Federico Mena Quintero's avatar
      Add a comment - Federico · c5d43cdb
      Federico Mena Quintero authored
      c5d43cdb
    • Federico Mena Quintero's avatar
      New file with a set of tests for GtkCellRendererText. The idea is to run a · 3e9f549d
      Federico Mena Quintero authored
      2005-09-28  Federico Mena Quintero  <federico@ximian.com>
      
      	* tests/testcellrenderertext.c: New file with a set of tests for
      	GtkCellRendererText.  The idea is to run a text renderer through
      	most of its interesting property values to see that it works
      	correctly.
      
      	* tests/Makefile.am: Added testcellrenderertext.
      
      	* gtk/gtkfilechooserdefault.c (load_set_model): Mark the
      	entry/exit of this function for profiling.
      	(gtk_file_chooser_default_style_set): Mark the start/end of the
      	calls to the parent class and the the signal emission for profiling.
      3e9f549d
    • Federico Mena Quintero's avatar
      New file with a set of tests for GtkCellRendererText. The idea is to run a · 77b52249
      Federico Mena Quintero authored
      2005-09-28  Federico Mena Quintero  <federico@ximian.com>
      
      	* tests/testcellrenderertext.c: New file with a set of tests for
      	GtkCellRendererText.  The idea is to run a text renderer through
      	most of its interesting property values to see that it works
      	correctly.
      
      	* tests/Makefile.am: Added testcellrenderertext.
      
      	* gtk/gtkfilechooserdefault.c (load_set_model): Mark the
      	entry/exit of this function for profiling.
      	(gtk_file_chooser_default_style_set): Mark the start/end of the
      	calls to the parent class and the the signal emission for profiling.
      77b52249
  7. Sep 28, 2005
    • Tor Lillqvist's avatar
      The locale directory is passed to bindtextdomain() which isn't · 4ac3ee58
      Tor Lillqvist authored
      2005-09-29  Tor Lillqvist  <tml@novell.com>
      
      	* gtk/gtkmain.c (_gtk_get_localedir): The locale directory is
      	passed to bindtextdomain() which isn't UTF-8-aware, so convert to
      	system codepage using g_win32_locale_filename_from_utf8().
      	(#317457, Kazuki Iwamoto)
      4ac3ee58
    • Matthias Clasen's avatar
      Free mult_atoms here. (#317039, Paolo Borelli) · d1a3c8dc
      Matthias Clasen authored
      2005-09-28  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtkselection.c (_gtk_selection_request): Free mult_atoms
      	here. (#317039, Paolo Borelli)
      d1a3c8dc
    • Matthias Clasen's avatar
      Change header too · f5b53f13
      Matthias Clasen authored
      f5b53f13
    • Matthias Clasen's avatar
      Return the attributes to make this function work as boxed copy function. · 037e90b8
      Matthias Clasen authored
      2005-09-28  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtktexttag.c (gtk_text_attributes_ref): Return the attributes
      	to make this function work as boxed copy function.  (#317455,
      	Gustavo Carneiro)
      037e90b8
    • Matthias Clasen's avatar
      Don't unref NULL. (#316828, Tor Lillqvist) · d52e81d5
      Matthias Clasen authored
      2005-09-28  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtkclipboard.c (request_image_received_func): Don't unref
      	NULL.  (#316828, Tor Lillqvist)
      d52e81d5
    • Tor Lillqvist's avatar
      Include <config.h>. (#317444, Kazuki Iwamoto) · 2f4eb8fd
      Tor Lillqvist authored
      2005-09-28  Tor Lillqvist  <tml@novell.com>
      
      	* modules/input/imime.c: Include <config.h>. (#317444, Kazuki
      	Iwamoto)
      2f4eb8fd
    • Federico Mena Quintero's avatar
      Don't reload the current folder unnecessarily on ::map(). · 6cd6a0a2
      Federico Mena Quintero authored
      2005-09-27  Federico Mena Quintero  <federico@ximian.com>
      
      	Don't reload the current folder unnecessarily on ::map().
      
      	* gtk/gtkfilechooserprivate.h (ReloadState): New enum to represent
      	the reloading state.
      	(struct _GtkFileChooserDefault): Added a "reload_state" field.
      
      	* gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_init):
      	Initialize impl->reload_state.
      	(gtk_file_chooser_default_map): Check the impl->reload_state; load
      	a default folder if no folder has been set, or reload the current
      	one only if we had been unmapped first.
      	(gtk_file_chooser_default_update_current_folder): Set the
      	reload_state to RELOAD_HAS_FOLDER.
      	(gtk_file_chooser_default_unmap): Implement, and set the
      	reload_state to RELOAD_WAS_UNMAPPED.
      	(shortcuts_model_create): Don't call shortcuts_add_bookmarks()
      	here; they'll get (re)loaded on ::map() anyway.
      
      	* gtk/gtkfilechooserwidget.c
      	(gtk_file_chooser_widget_constructor): Don't set a default folder here.
      
      	* tests/autotestfilechooser.c (test_action_widgets): Don't take in
      	a dialog; build it ourselves.
      	(test_reload): New test to ensure that we don't load the default
      	folder more than once, and that we reload it when
      	unmapping/remapping.
      	(get_impl_from_dialog): New utility function.
      	(test_widgets_for_current_action): Use get_impl_from_dialog().
      6cd6a0a2
  8. Sep 27, 2005
    • Federico Mena Quintero's avatar
      Don't reload the current folder unnecessarily on ::map(). · 72851a22
      Federico Mena Quintero authored
      2005-09-27  Federico Mena Quintero  <federico@ximian.com>
      
      	Don't reload the current folder unnecessarily on ::map().
      
      	* gtk/gtkfilechooserprivate.h (ReloadState): New enum to represent
      	the reloading state.
      	(struct _GtkFileChooserDefault): Added a "reload_state" field.
      
      	* gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_init):
      	Initialize impl->reload_state.
      	(gtk_file_chooser_default_map): Check the impl->reload_state; load
      	a default folder if no folder has been set, or reload the current
      	one only if we had been unmapped first.
      	(gtk_file_chooser_default_update_current_folder): Set the
      	reload_state to RELOAD_HAS_FOLDER.
      	(gtk_file_chooser_default_unmap): Implement, and set the
      	reload_state to RELOAD_WAS_UNMAPPED.
      	(shortcuts_model_create): Don't call shortcuts_add_bookmarks()
      	here; they'll get (re)loaded on ::map() anyway.
      
      	* gtk/gtkfilechooserwidget.c
      	(gtk_file_chooser_widget_constructor): Don't set a default folder here.
      
      	* tests/autotestfilechooser.c (test_action_widgets): Don't take in
      	a dialog; build it ourselves.
      	(test_reload): New test to ensure that we don't load the default
      	folder more than once, and that we reload it when
      	unmapping/remapping.
      	(get_impl_from_dialog): New utility function.
      	(test_widgets_for_current_action): Use get_impl_from_dialog().
      72851a22
Loading