• Christophe Fergeau's avatar
    fontchooserwidget: Don't invalidate priv->font_iter in load_fonts · 77487fef
    Christophe Fergeau authored
    When using GtkFontChooserButton, the same GtkFontChooserWidget can be
    hidden and shown multiple times. When doing that, the font that was
    chosen the previous time should be the selected one in the
    GtkFontChooserWidget, however this does not work as expected and a
    somehow 'random' font gets selected (or none) instead.
    Every time the font chooser widget is shown, its style will be updated,
    causing gtk_font_chooser_widget_style_updated and then
    gtk_font_chooser_widget_load_fonts to be called.
    gtk_font_chooser_widget_load_fonts starts by clearing the GtkListStore
    listing the available fonts, repopulates it, and then makes sure the
    current font is selected.
    However, this does not work as expected, as during the call to
    gtk_list_store_clear, the cursor_changed_cb will be invoked multiple
    times when the GtkTreeView cursor gets moved when the line where the
    cursor currently is gets removed. This will cause the 'current font'
    state (priv->font_desc) to be unexpectedly modified, and when
    gtk_font_chooser_widget_load_fonts tries to reposition the cursor to the
    'current font', we won't get the expect result.
    This commit avoids that by making sure cursor_changed_cb does not get
    called when we call gtk_list_store_clear in
gtkfontchooserwidget.c 41.1 KB