Skip to content
  • Matthias Clasen's avatar
    GtkPlacesSidebar: Don't pile up duplicate bookmarks · b858d45e
    Matthias Clasen authored
    We get multiple notifications from the bookmark manager when
    something changes. Every time, we reconstruct the sidebar contents
    completely, by clearing the store. The bookmarks are added with
    async calls though, and the code was forgetting to cancel outstanding
    async requests, leading to multiple instances of the same bookmark
    getting added. Use the cancellable we already have to prevent that.
    
    This could be made much more efficient by not recreating the entire
    sidebar quite so often (3-5 times for a single bookmark rename).
    
    https://bugzilla.gnome.org/show_bug.cgi?id=737679
    b858d45e