Skip to content
  • Zhang Yanfei's avatar
    mm/sparsemem: fix a bug in free_map_bootmem when CONFIG_SPARSEMEM_VMEMMAP · 81556b02
    Zhang Yanfei authored
    
    
    We pass the number of pages which hold page structs of a memory section
    to free_map_bootmem().  This is right when !CONFIG_SPARSEMEM_VMEMMAP but
    wrong when CONFIG_SPARSEMEM_VMEMMAP.  When CONFIG_SPARSEMEM_VMEMMAP, we
    should pass the number of pages of a memory section to free_map_bootmem.
    
    So the fix is removing the nr_pages parameter.  When
    CONFIG_SPARSEMEM_VMEMMAP, we directly use the prefined marco
    PAGES_PER_SECTION in free_map_bootmem.  When !CONFIG_SPARSEMEM_VMEMMAP,
    we calculate page numbers needed to hold the page structs for a memory
    section and use the value in free_map_bootmem().
    
    This was found by reading the code.  And I have no machine that support
    memory hot-remove to test the bug now.
    
    Signed-off-by: default avatarZhang Yanfei <zhangyanfei@cn.fujitsu.com>
    Reviewed-by: default avatarWanpeng Li <liwanp@linux.vnet.ibm.com>
    Cc: Wen Congyang <wency@cn.fujitsu.com>
    Cc: Tang Chen <tangchen@cn.fujitsu.com>
    Cc: Toshi Kani <toshi.kani@hp.com>
    Cc: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
    Cc: Yinghai Lu <yinghai@kernel.org>
    Cc: Yasunori Goto <y-goto@jp.fujitsu.com>
    Cc: Andy Whitcroft <apw@shadowen.org>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    81556b02