Skip to content
  • Mark Brown's avatar
    revert "drivers/video/s3c-fb.c: fix clock setting for Samsung SoC Framebuffer" · eb29a5cc
    Mark Brown authored
    Fix divide by zero and broken output.  Commit 600ce1a0
    
     ("fix clock
    setting for Samsung SoC Framebuffer") introduced a mandatory refresh
    parameter to the platform data for the S3C framebuffer but did not
    introduce any validation code, causing existing platforms (none of which
    have refresh set) to divide by zero whenever the framebuffer is
    configured, generating warnings and unusable output.
    
    Ben Dooks noted several problems with the patch:
    
     - The platform data supplies the pixclk directly and should already
       have taken care of the refresh rate.
     - The addition of a window ID parameter doesn't help since only the
       root framebuffer can control the pixclk.
     - pixclk is specified in picoseconds (rather than Hz) as the patch
       assumed.
    
    and suggests reverting the commit so do that.  Without fixing this no
    mainline user of the driver will produce output.
    
    [akpm@linux-foundation.org: don't revert the correct bit]
    Signed-off-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
    Cc: InKi Dae <inki.dae@samsung.com>
    Cc: Kyungmin Park <kmpark@infradead.org>
    Cc: Krzysztof Helt <krzysztof.h1@poczta.fm>
    Cc: Marek Szyprowski <m.szyprowski@samsung.com>
    Cc: Ben Dooks <ben-linux@fluff.org>
    Cc: <stable@kernel.org>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    eb29a5cc