iscsi-target: remove support for obsolete markers
Support for markers is currently broken because of a bug in iscsi_enforce_integrity_rules(): the "IFMarkInt_Reject" and "OFMarkInt_Reject" variables are always equal to 1 in iscsi_enforce_integrity_rules(). Moreover, fixed interval markers keys (IFMarker, OFMarker, IFMarkInt and OFMarkInt) are obsolete according to iSCSI RFC 7143: >From http://tools.ietf.org/html/rfc7143#section-13.25 : 13.25. Obsoleted Keys This document obsoletes the following keys defined in [RFC3720]: IFMarker, OFMarker, OFMarkInt, and IFMarkInt. However, iSCSI implementations compliant to this document may still receive these obsoleted keys -- i.e., in a responder role -- in a text negotiation. When an IFMarker or OFMarker key is received, a compliant iSCSI implementation SHOULD respond with the constant "Reject" value. The implementation MAY alternatively respond with a "No" value. However, the implementation MUST NOT respond with a "NotUnderstood" value for either of these keys. When an IFMarkInt or OFMarkInt key is received, a compliant iSCSI implementation MUST respond with the constant "Reject" value. The implementation MUST NOT respond with a "NotUnderstood" value for either of these keys. This patch disables markers by turning the corresponding parameters to read-only. The default value of IFMarker and OFMarker remains "No" but the user cannot change it to "Yes" anymore. The new value of IFMarkInt and OFMarkInt is "Reject". (Drop left-over iscsi_get_value_from_number_range + make configfs parameters attrs R/W nops - nab) Signed-off-by: Christophe Vu-Brugier <cvubrugier@fastmail.fm> Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Showing
- drivers/target/iscsi/iscsi_target.c 4 additions, 16 deletionsdrivers/target/iscsi/iscsi_target.c
- drivers/target/iscsi/iscsi_target_erl0.c 0 additions, 53 deletionsdrivers/target/iscsi/iscsi_target_erl0.c
- drivers/target/iscsi/iscsi_target_erl0.h 0 additions, 1 deletiondrivers/target/iscsi/iscsi_target_erl0.h
- drivers/target/iscsi/iscsi_target_login.c 1 addition, 57 deletionsdrivers/target/iscsi/iscsi_target_login.c
- drivers/target/iscsi/iscsi_target_login.h 0 additions, 1 deletiondrivers/target/iscsi/iscsi_target_login.h
- drivers/target/iscsi/iscsi_target_parameters.c 6 additions, 261 deletionsdrivers/target/iscsi/iscsi_target_parameters.c
- drivers/target/iscsi/iscsi_target_parameters.h 5 additions, 6 deletionsdrivers/target/iscsi/iscsi_target_parameters.h
- drivers/target/iscsi/iscsi_target_util.c 0 additions, 48 deletionsdrivers/target/iscsi/iscsi_target_util.c
- drivers/target/iscsi/iscsi_target_util.h 0 additions, 1 deletiondrivers/target/iscsi/iscsi_target_util.h
- include/target/iscsi/iscsi_target_core.h 0 additions, 10 deletionsinclude/target/iscsi/iscsi_target_core.h
Please register or sign in to comment