- Sep 20, 2017
-
-
aschmitz authored
* Fix JavaScript interface with long IDs Somewhat predictably, the JS interface handled IDs as numbers, which in JS are IEEE double-precision floats. This loses some precision when working with numbers as large as those generated by the new ID scheme, so we instead handle them here as strings. This is relatively simple, and doesn't appear to have caused any problems, but should definitely be tested more thoroughly than the built-in tests. Several days of use appear to support this working properly. BREAKING CHANGE: The major(!) change here is that IDs are now returned as strings by the REST endpoints, rather than as integers. In practice, relatively few changes were required to make the existing JS UI work with this change, but it will likely hit API clients pretty hard: it's an entirely different type to consume. (The one API client I tested, Tusky, handles this with no problems, however.) Twitter ran into this issue when introducing Snowflake IDs, and decided to instead introduce an `id_str` field in JSON responses. I have opted to *not* do that, and instead force all IDs to 64-bit integers represented by strings in one go. (I believe Twitter exacerbated their problem by rolling out the changes three times: once for statuses, once for DMs, and once for user IDs, as well as by leaving an integer ID value in JSON. As they said, "If you’re using the `id` field with JSON in a Javascript-related language, there is a very high likelihood that the integers will be silently munged by Javascript interpreters. In most cases, this will result in behavior such as being unable to load or delete a specific direct message, because the ID you're sending to the API is different than the actual identifier associated with the message." [1]) However, given that this is a significant change for API users, alternatives or a transition time may be appropriate. 1: https://blog.twitter.com/developer/en_us/a/2011/direct-messages-going-snowflake-on-sep-30-2011.html * Additional fixes for stringified IDs in JSON These should be the last two. These were identified using eslint to try to identify any plain casts to JavaScript numbers. (Some such casts are legitimate, but these were not.) Adding the following to .eslintrc.yml will identify casts to numbers: ~~~ no-restricted-syntax: - warn - selector: UnaryExpression[operator='+'] > :not(Literal) message: Avoid the use of unary + - selector: CallExpression[callee.name='Number'] message: Casting with Number() may coerce string IDs to numbers ~~~ The remaining three casts appear legitimate: two casts to array indices, one in a server to turn an environment variable into a number. * Back out RelationshipsController Change This was made to make a test a bit less flakey, but has nothing to do with this branch. * Change internal streaming payloads to stringified IDs as well Per https://github.com/tootsuite/mastodon/pull/5019#issuecomment-330736452 we need these changes to send deleted status IDs as strings, not integers.
-
- Sep 16, 2017
-
-
Naoki Kosaka authored
-
- Sep 15, 2017
-
-
unarist authored
* Fix behavior while the button is invisible e.g. pointer cursor, couldn't open contextmenu * Avoid rendering the button to remove blank space if no more items are available or no items are rendered
-
- Sep 14, 2017
-
-
Eugen Rochko authored
* Redesign video player * Use new video player on static public pages too * Use media gallery component on static public pages too * Pause video when hiding it * Full-screen sizing on WebKit * Add aria labels to video player buttons * Display link card on public status page * Fix fullscreen from modal sizing issue * Remove contain: strict property to fix fullscreen from columns
-
- Sep 13, 2017
-
-
abcang authored
-
- Sep 09, 2017
-
-
Eugen Rochko authored
It wasn't working ideally and introduced some annoying false positivies
-
unarist authored
Resolved: * Lot of redundant renders while mouse moving * Scroll jumping when timeline loaded * Scroll position isn't kept when statuses below the scrollTop was deleted then new status arrived Unresolved: * Scroll position isn't kept when statuses over the scrollTop was deleted then new status arrived -> It needs to know which statuses are over the scrollTop * New status indicator should be active when new statuses arrived while mouse moved recently -> It needs a) update indicator in ScrollableList, or b) set scrollTop status while mouse moving
-
Eugen Rochko authored
-
- Sep 08, 2017
-
-
Eugen Rochko authored
That way you can mute notifications for a toot before you get replies to it or boosts or favourites
-
- Sep 07, 2017
-
-
PFM authored
-
- Sep 06, 2017
- Sep 02, 2017
-
-
Yamagishi Kazutoshi authored
* Disable embed modal when private status * Remove `reblogDisabled`
-
- Sep 01, 2017
-
-
Eugen Rochko authored
* Add embed button to dropdowns of in-timeline statuses * yarn run manage:translations
-
- Aug 31, 2017
-
-
Akihiko Odaki authored
-
- Aug 28, 2017
-
-
abcang authored
-
- Aug 24, 2017
-
-
Eugen Rochko authored
* Pinned statuses * yarn manage:translations
-
- Aug 07, 2017
-
-
Sorin Davidoi authored
* feat: Cache status height to avoid expensive renders * feat: Escape content and emojify in reducers * fix(css): Remove backface-visibility: hidden from .scrollable * fix(statuses): Avoid creating DOMParses inside a loop
-
Ondřej Hruška authored
* Refactored Avatar and AvatarOverlay (DRY) to have 'account' as prop. Also removed animate attribute from compose navigation bar, which should have never been there. Added test for avatar overlay. * fix broken tests * god dammit another bug in tests! travis please let this pass * formatting in avatar overlay
-
- Aug 04, 2017
-
-
Akihiko Odaki authored
The feature to pin column could hide the rightmost column, which is specified with children property of ColumnsArea. The user is likely to see the column when the property changed, so scroll the area in such cases.
-
- Aug 02, 2017
-
-
Sorin Davidoi authored
-
- Jul 30, 2017
-
-
Sorin Davidoi authored
* fix(media_modal): Keyboard navigation * fix(column_back_button): Use native button * fix(media_gallery): Keyboard navigation * fix(status_content): Make CW content focusable
-
- Jul 29, 2017
-
-
unarist authored
-
- Jul 28, 2017
-
-
Sorin Davidoi authored
* fix(status_action_bar): Use aria-pressed for reblog and favourite button * fix(column_back_button): Keyboard accessible * fix(status_content): Make focusable and accessible * fix(dropdown_menu): Use aria-expanded instead of aria-pressed * fix(emoji_picker_dropdown): Use aria-expanded instead of aria-hidden * feat(icon_button): Add aria-expanded * fix(privacy_dropdown): Use aria-expanded instead of aria-hidden
-
Sorin Davidoi authored
* fix(modal_root): Read type from props, not from component * fix(status_list): Do not user event.path
-
Sorin Davidoi authored
* fix(status): Add tabIndex=0 * fix(status_list): Make keyboard navigable
-
Yamagishi Kazutoshi authored
-
Sorin Davidoi authored
* fix(dropdown_menu): Keyboard navigation * fix(icon_button): Add aria-pressed attribute * fix(privacy_dropdown): Make accessible * fix(emoji_picker_dropdown): Make accessible * fix(icon_button): Support tabIndex * fix(actions_modal): Remove icon from tab order * fix(dropdown_menu): Add role=group * fix(setting_toggle): Toggle via space key * fix(dropdown_menu): Remove redundant handling of Space key * fix(emoji_picker_dropdown): Remove redundant Space key handling * fix(privacy_dropdown): Remove redundant Space key handling * fix(status): Switch to article and add aria-posinset, aria-setsize * fix(status_list): Use role=feed and pass more ARIA props to Status * chore(eslint): jsx-a11y/role-supports-aria-props
-
- Jul 27, 2017
-
-
Sorin Davidoi authored
* fix(compose): Add aria-label for the navigation links * fix(search): Add input label * fix(navigation_bar): Link description * fix(autosuggest_textarea): Add input label * fix(compose_form): Add input label * fix(upload_button): Add input label * fix(account/header): Add link content * fix(column_header): Use h1 tag * fix(column_header): Labels move buttons moving column * fix(settings_text): Add label to input * fix(column_header): Remove role from h1 * fix(modal_root): Use role=dialog * fix(modal_root): Focus restauration * fix(modal_root): Apply inert to sibligs * fix(column_header): Add role=button * chore(eslint): Disable jsx-a11y/label-has-for
-
Sorin Davidoi authored
* fix(dropdown_menu): Open as modal on mobile * fix(dropdown_menu): Open modal on touch * fix(dropdown_menu): Show status * fix(dropdown_menu): Max dimensions and reduce padding * chore(dropdown_menu): Test new functionality * refactor: Use DropdownMenuContainer instead of DropdownMenu * feat(privacy_dropdown): Open as modal on touch devices * feat(modal_root): Do not load actions-modal async
-
Yamagishi Kazutoshi authored
-
- Jul 26, 2017
-
-
Eugen Rochko authored
-
Sorin Davidoi authored
* fix(column_header): Invalid ARIA role * fix(column): Remove hidden nodes from the DOM * refactor(column_link): Remove unused property hideOnMobile * fix(column_header): Use aria-pressed * fix(column_header): Make collapsed content not focusable, add focusable property * fix(column_loading): Make header non-focusable * fix(column_settings): Use role to group the toggles
-
Sorin Davidoi authored
* fix(compose): Use nav and remove redundant aria-label * fix(tabs_tab): Use nav and add aria-label * fix(app): Add aria-label for settings toggle button * chore: Run yarn manage:translations
-
- Jul 25, 2017
-
-
Sorin Davidoi authored
-
Sorin Davidoi authored
-
- Jul 24, 2017
-
-
Sorin Davidoi authored
* chore(yarn): Install detect-passive-events * fix(column): Use passive listener
-
- Jul 23, 2017
-
-
Eugen Rochko authored
-
- Jul 19, 2017
-
-
Sorin Davidoi authored
-
unarist authored
-