Skip to content
Snippets Groups Projects
  1. Oct 05, 2017
    • Eugen Rochko's avatar
      Implement hotkeys for web UI (#5164) · 7db0f8dc
      Eugen Rochko authored
      * Fix #2102 - Implement hotkeys
      
      Hotkeys on status list:
      
      - r to reply
      - m to mention author
      - f to favourite
      - b to boost
      - enter to open status
      - p to open author's profile
      - up or k to move up in the list
      - down or j to move down in the list
      - 1-9 to focus a status in one of the columns
      - n to focus the compose textarea
      - alt+n to start a brand new toot
      - backspace to navigate back
      
      * Add navigational hotkeys
      
      The key g followed by:
      
      - s: start
      - h: home
      - n: notifications
      - l: local timeline
      - t: federated timeline
      - f: favourites
      - u: own profile
      - p: pinned toots
      - b: blocked users
      - m: muted users
      
      * Add hotkey for focusing search, make escape un-focus compose/search
      
      * Fix focusing notifications column, fix hotkeys in compose textarea
      7db0f8dc
    • Eugen Rochko's avatar
    • Eugen Rochko's avatar
      When processing custom emoji, ensure a non-animated version exists (#5230) · b9c76e2e
      Eugen Rochko authored
      Use the non-animated version in web UI, but return both in API
      b9c76e2e
  2. Oct 04, 2017
    • ThibG's avatar
      Fix regression in FetchRemoteResourceService (#5217) · 2559d916
      ThibG authored
      * Fix regression in FetchRemoteResourceService
      
      * Update specs to match interface changes made in #5114
      2559d916
    • Lynx Kotoura's avatar
      adjust public profile pages 2 (#5223) · 32e8a878
      Lynx Kotoura authored
      32e8a878
    • Eugen Rochko's avatar
    • Lynx Kotoura's avatar
      43577e9f
    • MitarashiDango's avatar
    • utam0k's avatar
      Implement EmailBlackList (#5109) · b3af3f9f
      utam0k authored
      * Implement BlacklistedEmailDomain
      
      * Use Faker::Internet.domain_name
      
      * Remove note column
      
      * Add frozen_string_literal comment
      
      * Delete unnecessary codes
      
      * Sort alphabetically
      
      * Change of wording
      
      * Rename BlacklistedEmailDomain to EmailDomainBlock
      b3af3f9f
    • Ryo Kajiwara's avatar
    • Yamagishi Kazutoshi's avatar
      Separate notifications preferences from general preferences (#4447) · 178f718a
      Yamagishi Kazutoshi authored
      * Separate notifications preferences from general preferences
      
      * Refine settings/notifications/show
      
      * remove preferences.notifications
      178f718a
    • ThibG's avatar
      Check Webfinger-returned author URI even when not redirected (#5213) · 0e1b0f27
      ThibG authored
      The whole point of verified_webfinger? is to check the WebFinger-discoverable
      URI maps back to the known author URI. This was not actually verified if the
      first Webfinger request was not a redirection.
      0e1b0f27
    • aschmitz's avatar
      Non-Serial ("Snowflake") IDs (#4801) · 468523f4
      aschmitz authored
      * Use non-serial IDs
      
      This change makes a number of nontrivial tweaks to the data model in
      Mastodon:
      
      * All IDs are now 8 byte integers (rather than mixed 4- and 8-byte)
      * IDs are now assigned as:
        * Top 6 bytes: millisecond-resolution time from epoch
        * Bottom 2 bytes: serial (within the millisecond) sequence number
        * See /lib/tasks/db.rake's `define_timestamp_id` for details, but
          note that the purpose of these changes is to make it difficult to
          determine the number of objects in a table from the ID of any
          object.
      * The Redis sorted set used for the feed will have values used to look
        up toots, rather than scores. This is almost always the same as the
        existing behavior, except in the case of boosted toots. This change
        was made because Redis stores scores as double-precision floats,
        which cannot store the new ID format exactly. Note that this doesn't
        cause problems with sorting/pagination, because ZREVRANGEBYSCORE
        sorts lexicographically when scores are tied. (This will still cause
        sorting issues when the ID gains a new significant digit, but that's
        extraordinarily uncommon.)
      
      Note a couple of tradeoffs have been made in this commit:
      
      * lib/tasks/db.rake is used to enforce many/most column constraints,
        because this commit seems likely to take a while to bring upstream.
        Enforcing a post-migrate hook is an easier way to maintain the code
        in the interim.
      * Boosted toots will appear in the timeline as many times as they have
        been boosted. This is a tradeoff due to the way the feed is saved in
        Redis at the moment, but will be handled by a future commit.
      
      This would effectively close Mastodon's #1059, as it is a
      snowflake-like system of generating IDs. However, given how involved
      the changes were simply within Mastodon, it may have unexpected
      interactions with some clients, if they store IDs as doubles
      (or as 4-byte integers). This was a problem that Twitter ran into with
      their "snowflake" transition, particularly in JavaScript clients that
      treated IDs as JS integers, rather than strings. It therefore would be
      useful to test these changes at least in the web interface and popular
      clients before pushing them to all users.
      
      * Fix JavaScript interface with long IDs
      
      Somewhat predictably, the JS interface handled IDs as numbers, which in
      JS are IEEE double-precision floats. This loses some precision when
      working with numbers as large as those generated by the new ID scheme,
      so we instead handle them here as strings. This is relatively simple,
      and doesn't appear to have caused any problems, but should definitely
      be tested more thoroughly than the built-in tests. Several days of use
      appear to support this working properly.
      
      BREAKING CHANGE:
      
      The major(!) change here is that IDs are now returned as strings by the
      REST endpoints, rather than as integers. In practice, relatively few
      changes were required to make the existing JS UI work with this change,
      but it will likely hit API clients pretty hard: it's an entirely
      different type to consume. (The one API client I tested, Tusky, handles
      this with no problems, however.)
      
      Twitter ran into this issue when introducing Snowflake IDs, and decided
      to instead introduce an `id_str` field in JSON responses. I have opted
      to *not* do that, and instead force all IDs to 64-bit integers
      represented by strings in one go. (I believe Twitter exacerbated their
      problem by rolling out the changes three times: once for statuses, once
      for DMs, and once for user IDs, as well as by leaving an integer ID
      value in JSON. As they said, "If you’re using the `id` field with JSON
      in a Javascript-related language, there is a very high likelihood that
      the integers will be silently munged by Javascript interpreters. In most
      cases, this will result in behavior such as being unable to load or
      delete a specific direct message, because the ID you're sending to the
      API is different than the actual identifier associated with the
      message." [1]) However, given that this is a significant change for API
      users, alternatives or a transition time may be appropriate.
      
      1: https://blog.twitter.com/developer/en_us/a/2011/direct-messages-going-snowflake-on-sep-30-2011.html
      
      * Restructure feed pushes/unpushes
      
      This was necessary because the previous behavior used Redis zset scores
      to identify statuses, but those are IEEE double-precision floats, so we
      can't actually use them to identify all 64-bit IDs. However, it leaves
      the code in a much better state for refactoring reblog handling /
      coalescing.
      
      Feed-management code has been consolidated in FeedManager, including:
      
      * BatchedRemoveStatusService no longer directly manipulates feed zsets
      * RemoveStatusService no longer directly manipulates feed zsets
      * PrecomputeFeedService has moved its logic to FeedManager#populate_feed
      
      (PrecomputeFeedService largely made lots of calls to FeedManager, but
      didn't follow the normal adding-to-feed process.)
      
      This has the effect of unifying all of the feed push/unpush logic in
      FeedManager, making it much more tractable to update it in the future.
      
      Due to some additional checks that must be made during, for example,
      batch status removals, some Redis pipelining has been removed. It does
      not appear that this should cause significantly increased load, but if
      necessary, some optimizations are possible in batch cases. These were
      omitted in the pursuit of simplicity, but a batch_push and batch_unpush
      would be possible in the future.
      
      Tests were added to verify that pushes happen under expected conditions,
      and to verify reblog behavior (both on pushing and unpushing). In the
      case of unpushing, this includes testing behavior that currently leads
      to confusion such as Mastodon's #2817, but this codifies that the
      behavior is currently expected.
      
      * Rubocop fixes
      
      I could swear I made these changes already, but I must have lost them
      somewhere along the line.
      
      * Address review comments
      
      This addresses the first two comments from review of this feature:
      
      https://github.com/tootsuite/mastodon/pull/4801#discussion_r139336735
      https://github.com/tootsuite/mastodon/pull/4801#discussion_r139336931
      
      This adds an optional argument to FeedManager#key, the subtype of feed
      key to generate. It also tests to ensure that FeedManager's settings are
      such that reblogs won't be tracked forever.
      
      * Hardcode IdToBigints migration columns
      
      This addresses a comment during review:
      https://github.com/tootsuite/mastodon/pull/4801#discussion_r139337452
      
      This means we'll need to make sure that all _id columns going forward
      are bigints, but that should happen automatically in most cases.
      
      * Additional fixes for stringified IDs in JSON
      
      These should be the last two. These were identified using eslint to try
      to identify any plain casts to JavaScript numbers. (Some such casts are
      legitimate, but these were not.)
      
      Adding the following to .eslintrc.yml will identify casts to numbers:
      
      ~~~
        no-restricted-syntax:
        - warn
        - selector: UnaryExpression[operator='+'] > :not(Literal)
          message: Avoid the use of unary +
        - selector: CallExpression[callee.name='Number']
          message: Casting with Number() may coerce string IDs to numbers
      ~~~
      
      The remaining three casts appear legitimate: two casts to array indices,
      one in a server to turn an environment variable into a number.
      
      * Only implement timestamp IDs for Status IDs
      
      Per discussion in #4801, this is only being merged in for Status IDs at
      this point. We do this in a migration, as there is no longer use for
      a post-migration hook. We keep the initialization of the timestamp_id
      function as a Rake task, as it is also needed after db:schema:load (as
      db/schema.rb doesn't store Postgres functions).
      
      * Change internal streaming payloads to stringified IDs as well
      
      This is equivalent to 591a9af356faf2d5c7e66e3ec715502796c875cd from
      #5019, with an extra change for the addition to FeedManager#unpush.
      
      * Ensure we have a status_id_seq sequence
      
      Apparently this is not a given when specifying a custom ID function,
      so now we ensure it gets created. This uses the generic version of this
      function to more easily support adding additional tables with timestamp
      IDs in the future, although it would be possible to cut this down to a
      less generic version if necessary. It is only run during db:schema:load
      or the relevant migration, so the overhead is extraordinarily minimal.
      
      * Transition reblogs to new Redis format
      
      This provides a one-way migration to transition old Redis reblog entries
      into the new format, with a separate tracking entry for reblogs.
      
      It is not invertible because doing so could (if timestamp IDs are used)
      require a database query for each status in each users' feed, which is
      likely to be a significant toll on major instances.
      
      * Address review comments from @akihikodaki
      
      No functional changes.
      
      * Additional review changes
      
      * Heredoc cleanup
      
      * Run db:schema:load hooks for test in development
      
      This matches the behavior in Rails'
      ActiveRecord::Tasks::DatabaseTasks.each_current_configuration, which
      would otherwise break `rake db:setup` in development.
      
      It also moves some functionality out to a library, which will be a good
      place to put additional related functionality in the near future.
      468523f4
    • Yamagishi Kazutoshi's avatar
  3. Oct 03, 2017
  4. Oct 02, 2017
    • Eugen Rochko's avatar
      5e5f36c2
    • m4sk1n's avatar
      i18n: Update translation files and Polish translation (#5180) · a767ef85
      m4sk1n authored
      
      * Update translation files
      
      Signed-off-by: default avatarMarcin Mikołajczak <me@m4sk.in>
      
      * i18n: Update Polish translation
      
      Signed-off-by: default avatarMarcin Mikołajczak <me@m4sk.in>
      a767ef85
    • Jeong Arm's avatar
      Fix stupid typo (#5184) · 0db47196
      Jeong Arm authored
      0db47196
    • Jeong Arm's avatar
      Korean translation (#5185) · c30e4925
      Jeong Arm authored
      * Add missing Korean translations
      
      * Add Korean email confirmation template
      
      * Fix Korean typo
      c30e4925
    • aschmitz's avatar
      Make IdsToBigints (mostly!) non-blocking (#5088) · 97c02c33
      aschmitz authored
      * Make IdsToBigints (mostly!) non-blocking
      
      This pulls in GitLab's MigrationHelpers, which include code to make
      column changes in ways that Postgres can do without locking. In general,
      this involves creating a new column, adding an index and any foreign
      keys as appropriate, adding a trigger to keep it populated alongside
      the old column, and then progressively copying data over to the new
      column, before removing the old column and replacing it with the new
      one.
      
      A few changes to GitLab's MigrationHelpers were necessary:
      
      * Some changes were made to remove dependencies on other GitLab code.
      * We explicitly wait for index creation before forging ahead on column
        replacements.
      * We use different temporary column names, to avoid running into index
        name length limits.
      * We rename the generated indices back to what they "should" be after
        replacing columns.
      * We rename the generated foreign keys to use the new column names when
        we had to create them. (This allows the migration to be rolled back
        without incident.)
      
      # Big Scary Warning
      
      There are two things here that may trip up large instances:
      
      1. The change for tables' "id" columns is not concurrent. In
         particular, the stream_entries table may be big, and does not
         concurrently migrate its id column. (On the other hand, x_id type
         columns are all concurrent.)
      2. This migration will take a long time to run, *but it should not
         lock tables during that time* (with the exception of the "id"
         columns as described above). That means this should probably be run
         in `screen` or some other session that can be run for a long time.
         Notably, the migration will take *longer* than it would without
         these changes, but the website will still be responsive during that
         time.
      
      These changes were tested on a relatively large statuses table (256k
      entries), and the service remained responsive during the migration.
      Migrations both forward and backward were tested.
      
      * Rubocop fixes
      
      * MigrationHelpers: Support ID columns in some cases
      
      This doesn't work in cases where the ID column is referred to as a
      foreign key by another table.
      
      * MigrationHelpers: support foreign keys for ID cols
      
      Note that this does not yet support foreign keys on non-primary-key
      columns, but Mastodon also doesn't yet have any that we've needed to
      migrate.
      
      This means we can perform fully "concurrent" migrations to change ID
      column types, and the IdsToBigints migration can happen with effectively
      no downtime. (A few operations require a transaction, such as renaming
      columns or deleting them, but these transactions should not block for
      noticeable amounts of time.)
      
      The algorithm for generating foreign key names has changed with this,
      and therefore all of those changed in schema.rb.
      
      * Provide status, allow for interruptions
      
      The MigrationHelpers now allow restarting the rename of a column if it
      was interrupted, by removing the old "new column" and re-starting the
      process.
      
      Along with this, they now provide status updates on the changes which
      are happening, as well as indications about when the changes can be
      safely interrupted (when there are at least 10 seconds estimated to be
      left before copying data is complete).
      
      The IdsToBigints migration now also sorts the columns it migrates by
      size, starting with the largest tables. This should provide
      administrators a worst-case scenario estimate for the length of
      migrations: each successive change will get faster, giving admins a
      chance to abort early on if they need to run the migration later. The
      idea is that this does not force them to try to time interruptions
      between smaller migrations.
      
      * Fix column sorting in IdsToBigints
      
      Not a significant change, but it impacts the order of columns in the
      database and db/schema.rb.
      
      * Actually pause before IdsToBigints
      97c02c33
    • Eugen Rochko's avatar
      Search popout (#5170) · 4453c9a9
      Eugen Rochko authored
      4453c9a9
    • Nolan Lawson's avatar
      b9c612b5
    • Jeong Arm's avatar
      Append confirmation link as plain text (#5146) · d841af4e
      Jeong Arm authored
      * Append confirmation link as plain text
      
      Some mail application is malfunctioning with links.
      
      * Change description text
      d841af4e
    • Daigo 3 Dango's avatar
      01d6aa03
    • Nolan Lawson's avatar
      Toggle contain:strict on fullscreen (#5159) · c567c874
      Nolan Lawson authored
      * Toggle contain:strict on fullscreen
      
      * Fix scss lint issue
      
      * fix scss whitespace lint issue
      c567c874
  5. Oct 01, 2017
Loading