Skip to content
Snippets Groups Projects
  1. Dec 05, 2017
  2. Nov 28, 2017
    • aschmitz's avatar
      Allow hiding of reblogs from followed users (#5762) · eeaec398
      aschmitz authored
      * Allow hiding of reblogs from followed users
      
      This adds a new entry to the account menu to allow users to hide
      future reblogs from a user (and then if they've done that, to show
      future reblogs instead).
      
      This does not remove or add historical reblogs from/to the user's
      timeline; it only affects new statuses.
      
      The API for this operates by sending a "reblogs" key to the follow
      endpoint. If this is sent when starting a new follow, it will be
      respected from the beginning of the follow relationship (even if
      the follow request must be approved by the followee). If this is
      sent when a follow relationship already exists, it will simply
      update the existing follow relationship. As with the notification
      muting, this will now return an object ({reblogs: [true|false]}) or
      false for each follow relationship when requesting relationship
      information for an account. This should cause few issues due to an
      object being truthy in many languages, but some modifications may
      need to be made in pickier languages.
      
      Database changes: adds a show_reblogs column (default true,
      non-nullable) to the follows and follow_requests tables. Because
      these are non-nullable, we use the existing MigrationHelpers to
      perform this change without locking those tables, although the
      tables are likely to be small anyway.
      
      Tests included.
      
      See also <https://github.com/glitch-soc/mastodon/pull/212>.
      
      * Rubocop fixes
      
      * Code review changes
      
      * Test fixes
      
      This patchset closes #648 and resolves #3271.
      
      * Rubocop fix
      
      * Revert reblogs defaulting in argument, fix tests
      
      It turns out we needed this for the same reason we needed it in muting:
      if nil gets passed in somehow (most usually by an API client not passing
      any value), we need to detect and handle it.
      
      We could specify a default in the parameter and then also catch nil, but
      there's no great reason to duplicate the default value.
      eeaec398
  3. Nov 25, 2017
  4. Nov 15, 2017
    • Surinna Curtis's avatar
      Optional notification muting (#5087) · 031a5a8f
      Surinna Curtis authored
      * Add a hide_notifications column to mutes
      
      * Add muting_notifications? and a notifications argument to mute!
      
      * block notifications in notify_service from hard muted accounts
      
      * Add specs for how mute! interacts with muting_notifications?
      
      * specs testing that hide_notifications in mutes actually hides notifications
      
      * Add support for muting notifications in MuteService
      
      * API support for muting notifications (and specs)
      
      * Less gross passing of notifications flag
      
      * Break out a separate mute modal with a hide-notifications checkbox.
      
      * Convert profile header mute to use mute modal
      
      * Satisfy eslint.
      
      * specs for MuteService notifications params
      
      * add trailing newlines to files for Pork :)
      
      * Put the label for the hide notifications checkbox in a label element.
      
      * Add a /api/v1/mutes/details route that just returns the array of mutes.
      
      * Define a serializer for /api/v1/mutes/details
      
      * Add more specs for the /api/v1/mutes/details endpoint
      
      * Expose whether a mute hides notifications in the api/v1/relationships endpoint
      
      * Show whether muted users' notifications are muted in account lists
      
      * Allow modifying the hide_notifications of a mute with the /api/v1/accounts/:id/mute endpoint
      
      * make the hide/unhide notifications buttons work
      
      * satisfy eslint
      
      * In probably dead code, replace a dispatch of muteAccount that was skipping the modal with launching the mute modal.
      
      * fix a missing import
      
      * add an explanatory comment to AccountInteractions
      
      * Refactor handling of default params for muting to make code cleaner
      
      * minor code style fixes oops
      
      * Fixed a typo that was breaking the account mute API endpoint
      
      * Apply white-space: nowrap to account relationships icons
      
      * Fix code style issues
      
      * Remove superfluous blank line
      
      * Rename /api/v1/mutes/details -> /api/v2/mutes
      
      * Don't serialize "account" in MuteSerializer
      
      Doing so is somewhat unnecessary since it's always the current user's account.
      
      * Fix wrong variable name in api/v2/mutes
      
      * Use Toggle in place of checkbox in the mute modal.
      
      * Make the Toggle in the mute modal look better
      
      * Code style changes in specs and removed an extra space
      
      * Code review suggestions from akihikodaki
      
      Also fixed a syntax error in tests for AccountInteractions.
      
      * Make AddHideNotificationsToMute Concurrent
      
      It's not clear how much this will benefit instances in practice, as the
      number of mutes tends to be pretty small, but this should prevent any
      blocking migrations nonetheless.
      
      * Fix up migration things
      
      * Remove /api/v2/mutes
      031a5a8f
  5. Oct 31, 2017
  6. Oct 29, 2017
  7. Oct 27, 2017
  8. Oct 26, 2017
  9. Oct 17, 2017
  10. Oct 16, 2017
  11. Oct 06, 2017
  12. Oct 05, 2017
    • Eugen Rochko's avatar
      Implement hotkeys for web UI (#5164) · 7db0f8dc
      Eugen Rochko authored
      * Fix #2102 - Implement hotkeys
      
      Hotkeys on status list:
      
      - r to reply
      - m to mention author
      - f to favourite
      - b to boost
      - enter to open status
      - p to open author's profile
      - up or k to move up in the list
      - down or j to move down in the list
      - 1-9 to focus a status in one of the columns
      - n to focus the compose textarea
      - alt+n to start a brand new toot
      - backspace to navigate back
      
      * Add navigational hotkeys
      
      The key g followed by:
      
      - s: start
      - h: home
      - n: notifications
      - l: local timeline
      - t: federated timeline
      - f: favourites
      - u: own profile
      - p: pinned toots
      - b: blocked users
      - m: muted users
      
      * Add hotkey for focusing search, make escape un-focus compose/search
      
      * Fix focusing notifications column, fix hotkeys in compose textarea
      7db0f8dc
  13. Oct 03, 2017
  14. Oct 02, 2017
  15. Sep 30, 2017
  16. Sep 29, 2017
  17. Sep 28, 2017
    • Eugen Rochko's avatar
      Add ability to specify alternative text for media attachments (#5123) · 4ec17711
      Eugen Rochko authored
      * Fix #117 - Add ability to specify alternative text for media attachments
      
      - POST /api/v1/media accepts `description` straight away
      - PUT /api/v1/media/:id to update `description` (only for unattached ones)
      - Serialized as `name` of Document object in ActivityPub
      - Uploads form adjusted for better performance and description input
      
      * Add tests
      
      * Change undo button blend mode to difference
      4ec17711
  18. Sep 25, 2017
  19. Sep 24, 2017
  20. Sep 23, 2017
  21. Sep 22, 2017
  22. Sep 20, 2017
    • aschmitz's avatar
      Change IDs to strings rather than numbers in API JSON output (#5019) · 669fe9ee
      aschmitz authored
      * Fix JavaScript interface with long IDs
      
      Somewhat predictably, the JS interface handled IDs as numbers, which in
      JS are IEEE double-precision floats. This loses some precision when
      working with numbers as large as those generated by the new ID scheme,
      so we instead handle them here as strings. This is relatively simple,
      and doesn't appear to have caused any problems, but should definitely
      be tested more thoroughly than the built-in tests. Several days of use
      appear to support this working properly.
      
      BREAKING CHANGE:
      
      The major(!) change here is that IDs are now returned as strings by the
      REST endpoints, rather than as integers. In practice, relatively few
      changes were required to make the existing JS UI work with this change,
      but it will likely hit API clients pretty hard: it's an entirely
      different type to consume. (The one API client I tested, Tusky, handles
      this with no problems, however.)
      
      Twitter ran into this issue when introducing Snowflake IDs, and decided
      to instead introduce an `id_str` field in JSON responses. I have opted
      to *not* do that, and instead force all IDs to 64-bit integers
      represented by strings in one go. (I believe Twitter exacerbated their
      problem by rolling out the changes three times: once for statuses, once
      for DMs, and once for user IDs, as well as by leaving an integer ID
      value in JSON. As they said, "If you’re using the `id` field with JSON
      in a Javascript-related language, there is a very high likelihood that
      the integers will be silently munged by Javascript interpreters. In most
      cases, this will result in behavior such as being unable to load or
      delete a specific direct message, because the ID you're sending to the
      API is different than the actual identifier associated with the
      message." [1]) However, given that this is a significant change for API
      users, alternatives or a transition time may be appropriate.
      
      1: https://blog.twitter.com/developer/en_us/a/2011/direct-messages-going-snowflake-on-sep-30-2011.html
      
      * Additional fixes for stringified IDs in JSON
      
      These should be the last two. These were identified using eslint to try
      to identify any plain casts to JavaScript numbers. (Some such casts are
      legitimate, but these were not.)
      
      Adding the following to .eslintrc.yml will identify casts to numbers:
      
      ~~~
        no-restricted-syntax:
        - warn
        - selector: UnaryExpression[operator='+'] > :not(Literal)
          message: Avoid the use of unary +
        - selector: CallExpression[callee.name='Number']
          message: Casting with Number() may coerce string IDs to numbers
      ~~~
      
      The remaining three casts appear legitimate: two casts to array indices,
      one in a server to turn an environment variable into a number.
      
      * Back out RelationshipsController Change
      
      This was made to make a test a bit less flakey, but has nothing to
      do with this branch.
      
      * Change internal streaming payloads to stringified IDs as well
      
      Per
      https://github.com/tootsuite/mastodon/pull/5019#issuecomment-330736452
      we need these changes to send deleted status IDs as strings, not
      integers.
      669fe9ee
  23. Sep 16, 2017
Loading