Add patch to fix broken strong instance search.
Currently Stream is broken because the function to search for "strong instances is broken.
This patch fixes it
Merge request reports
Activity
/cc @jeremiah.foster
I think you have the wrong repo: https://source.puri.sm/librem5-apps/Stream/-/blob/pureos/byzantium/debian/changelog is the packaging repo and https://source.puri.sm/todd/Stream is the upstream repo.
-
@guido.gunther this patch has also been submitted upstream. It has been accepted there.
There is a debate about this issue here:
-
@guido.gunther this patch has also been submitted upstream. It has been accepted there.
This should be noted in the patch or at least the commit message.
-
ahh..I see it here now !1 (diffs)
assigned to @joao.azevedo
added byzantium label
requested review from @jonas.smedegaard
- @joao.azevedo This looks good to me. Assigning to you for merge.
- @jonas.smedegaard I've requested a review from you as well before merge.
- Would be cool to close https://tracker.pureos.net/T1092 once this is done.
I am not familiar with the codebase, so simply assume it is functionally sensible.
From the perspective of my concern over keeping changes minimal ofr a stable release (which I guess is the reason you requested my review, @jeremiah.foster ) this patch certainly is minimal :-)
(containing metadata and markup for the patch could be more compact, but that's harmless - @joao.azevedo let me know if you are interested in tidier patches in future)
-
I made a mistake, this is not the correct repo for this package. This repo is a duplicate and should be archived, @jeremiah.foster can you archive this repo?
The correct repo is: https://source.puri.sm/librem5-apps/Stream
I will submit this patch there.