• Wenchao Xia's avatar
    snapshot: distinguish id and name in snapshot delete · a89d89d3
    Wenchao Xia authored
    Snapshot creation actually already distinguish id and name since it take
    a structured parameter *sn, but delete can't. Later an accurate delete
    is needed in qmp_transaction abort and blockdev-snapshot-delete-sync,
    so change its prototype. Also *errp is added to tip error, but return
    value is kepted to let caller check what kind of error happens. Existing
    caller for it are savevm, delvm and qemu-img, they are not impacted by
    introducing a new function bdrv_snapshot_delete_by_id_or_name(), which
    check the return value and do the operation again.
    Before this patch:
      For qcow2, it search id first then name to find the one to delete.
      For rbd, it search name.
      For sheepdog, it does nothing.
    After this patch:
      For qcow2, logic is the same by call it twice in caller.
      For rbd, it always fails in delete with id, but still search for name
    in second try, no change to user.
    Some code for *errp is based on Pavel's patch.
    Signed-off-by: default avatarWenchao Xia <xiawenc@linux.vnet.ibm.com>
    Signed-off-by: default avatarPavel Hrdina <phrdina@redhat.com>
    Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
savevm.c 65 KB