Skip to content
  • Daniel P. Berrangé's avatar
    rules: don't try to create missing include dirs · ac7568bd
    Daniel P. Berrangé authored
    In
    
      commit ba78db44
      Author: Daniel P. Berrange <berrange@redhat.com>
      Date:   Wed Jan 25 16:14:10 2017 +0000
    
      make: move top level dir to end of include search path
    
    The dir $(BUILD_DIR)/$(@D) was added to the include
    path. This would sometimes point to a non-existant
    directory, if the sub-dir in question did not contain
    any target-independant files (eg tcg/). To deal with
    this the rules.mak attempted to create the directory.
    
    While this was succesful, it also caused accidental
    creation of files in the parent of the build dir.
    e.g. when building common source files into target
    specific output files.
    
    Rather than trying to workaround this, just revert
    the code that attempted to mkdir the missing include
    directories. Instead just turn off the compiler warning
    in question as the missing dir is expected & harmless
    in general.
    
    NB: you can clean up a build directory parent that has
    been filled with empty directories by commit ba78db44
    
    
    using this GNU find command in that parent directory:
      find audio backends block chardev crypto disas fsdev hw io linux-user \
        migration nbd net qapi qom replay slirp target ui util \
        -type d -empty -delete
    
    Signed-off-by: default avatarDaniel P. Berrange <berrange@redhat.com>
    Tested-by: default avatarAlberto Garcia <berto@igalia.com>
    [PMM: added note about how to clean up a polluted directory]
    Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
    ac7568bd