Skip to content
  • Eric Blake's avatar
    qom: Swap 'name' next to visitor in ObjectPropertyAccessor · d7bce999
    Eric Blake authored
    
    
    Similar to the previous patch, it's nice to have all functions
    in the tree that involve a visitor and a name for conversion to
    or from QAPI to consistently stick the 'name' parameter next
    to the Visitor parameter.
    
    Done by manually changing include/qom/object.h and qom/object.c,
    then running this Coccinelle script and touching up the fallout
    (Coccinelle insisted on adding some trailing whitespace).
    
        @ rule1 @
        identifier fn;
        typedef Object, Visitor, Error;
        identifier obj, v, opaque, name, errp;
        @@
         void fn
        - (Object *obj, Visitor *v, void *opaque, const char *name,
        + (Object *obj, Visitor *v, const char *name, void *opaque,
           Error **errp) { ... }
    
        @@
        identifier rule1.fn;
        expression obj, v, opaque, name, errp;
        @@
         fn(obj, v,
        -   opaque, name,
        +   name, opaque,
            errp)
    
    Signed-off-by: default avatarEric Blake <eblake@redhat.com>
    Reviewed-by: default avatarMarc-André Lureau <marcandre.lureau@redhat.com>
    Message-Id: <1454075341-13658-20-git-send-email-eblake@redhat.com>
    Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
    d7bce999