Skip to content
  • David Hildenbrand's avatar
    numa: report all DIMM/NVDIMMs as plugged memory · 178003ea
    David Hildenbrand authored
    Right now, there is some inconsistency between hotplugged and
    coldplugged memory. DIMMs added via "-device" result in different stats
    than DIMMs added using "device_add".
    
    E.g.
        [...]
        -numa node,nodeid=0,cpus=0-1 -numa node,nodeid=1,cpus=2-3 \
        -m 4G,maxmem=20G,slots=2 \
        -object memory-backend-ram,id=mem0,size=8G \
        -device pc-dimm,id=dimm0,memdev=mem0 \
        -object memory-backend-ram,id=mem1,size=8G \
        -device nvdimm,id=dimm1,memdev=mem1,node=1
    
    Results in NUMA info
        (qemu) info numa
        info numa
        2 nodes
        node 0 cpus: 0 1
        node 0 size: 10240 MB
        node 0 plugged: 0 MB
        node 1 cpus: 2 3
        node 1 size: 10240 MB
        node 1 plugged: 0 MB
    
    But in memory size summary:
        (qemu) info memory_size_summary
        info memory_size_summary
        base memory: 4294967296
        plugged memory: 17179869184
    
    Make this consistent by reporting all hot and coldplugged
    memory a.k.a. DIMM and NVDIMM as "plugged".
    
    Fixes: 31959e82
    
     ("hmp: extend "info numa" with hotplugged memory information")
    Signed-off-by: default avatarDavid Hildenbrand <david@redhat.com>
    Message-Id: <20180622144045.737-1-david@redhat.com>
    Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
    178003ea