Skip to content
  • Kevin Wolf's avatar
    block: Convert .bdrv_truncate callback to coroutine_fn · 061ca8a3
    Kevin Wolf authored
    
    
    bdrv_truncate() is an operation that can block (even for a quite long
    time, depending on the PreallocMode) in I/O paths that shouldn't block.
    Convert it to a coroutine_fn so that we have the infrastructure for
    drivers to make their .bdrv_co_truncate implementation asynchronous.
    
    This change could potentially introduce new race conditions because
    bdrv_truncate() isn't necessarily executed atomically any more. Whether
    this is a problem needs to be evaluated for each block driver that
    supports truncate:
    
    * file-posix/win32, gluster, iscsi, nfs, rbd, ssh, sheepdog: The
      protocol drivers are trivially safe because they don't actually yield
      yet, so there is no change in behaviour.
    
    * copy-on-read, crypto, raw-format: Essentially just filter drivers that
      pass the request to a child node, no problem.
    
    * qcow2: The implementation modifies metadata, so it needs to hold
      s->lock to be safe with concurrent I/O requests. In order to avoid
      double locking, this requires pulling the locking out into
      preallocate_co() and using qcow2_write_caches() instead of
      bdrv_flush().
    
    * qed: Does a single header update, this is fine without locking.
    
    Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
    Reviewed-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
    061ca8a3