Skip to content
Snippets Groups Projects

history: Update schema to handle SMS/MMS specific details

Merged Mohammed Sadiq requested to merge mohammed.sadiq/chatty:wip/sadiq/mm-history into master

Update history schema to handle more details. Also add tests for migration and schema changes and adapt to changes

I'm thinking of bumping version to 0.6.x since this is a backward incompatible change and to skip 0.5.0 stable release (as 0.5.x currently skips saving many MMS details into history-db)

/cc @kop316

Edited by Mohammed Sadiq

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Chris Talbot
  • Chris Talbot
  • Mohammed Sadiq added 2 commits

    added 2 commits

    • 83d0faaf - mmsd: Add files as attachments to message
    • 0dd59a21 - text-item: Generate text content for multi file messages

    Compare with previous version

  • Mohammed Sadiq resolved all threads

    resolved all threads

  • Mohammed Sadiq marked this merge request as ready

    marked this merge request as ready

  • Mohammed Sadiq added 1 commit

    added 1 commit

    • 3d56ed97 - text-item: Generate text content for multi file messages

    Compare with previous version

    • Resolved by Mohammed Sadiq

      One thing that would be nice is if an MMS has a subject is to make it obvious in the UI like

      Subject: This is the subject!
      
      Message: This is the message!

      Since I controlled both sending and receiving, I knew what it was, but I think I would be confused otherwise.

  • Mohammed Sadiq added 3 commits

    added 3 commits

    • a7e95c9f - history: Update db design to handle more MMS features
    • 645d2c1e - mmsd: Add files as attachments to message
    • 30a71932 - text-item: Generate text content for multi file messages

    Compare with previous version

  • Mohammed Sadiq resolved all threads

    resolved all threads

  • Mohammed Sadiq added 1 commit

    added 1 commit

    • 3ee9d811 - text-item: Generate text content for multi file messages

    Compare with previous version

  • Mohammed Sadiq resolved all threads

    resolved all threads

  • I have removed the iccid column as it's not done the right way. As we don't use it right now, it's better for it to be added when we have a need for that (ie, when we support multiple modems at once and the ability to switch modems when sending messages)

  • ready to be mergeable /cc @guido.gunther @sebastian.krzyszkowiak your reviews would be good too (at least a cursory one, or testing with a real db)

  • Mohammed Sadiq added 8 commits

    added 8 commits

    • 3ee9d811...bdcd8d80 - 3 commits from branch Librem5:master
    • 1a7e579a - tests: Improve history tests
    • 5b7ff789 - message: Add API for message subject
    • 6443b9b9 - history: Update db design to handle more MMS features
    • 413bd827 - mmsd: Add files as attachments to message
    • 859b8d5a - text-item: Generate text content for multi file messages

    Compare with previous version

  • I tested this and it worked!

  • Mohammed Sadiq added 6 commits

    added 6 commits

    • 9a784bf3 - 1 commit from branch Librem5:master
    • 8ff271af - tests: Improve history tests
    • 0fc4fcab - message: Add API for message subject
    • 5d6b852d - history: Update db design to handle more MMS features
    • 7e8db6b5 - mmsd: Add files as attachments to message
    • a931ba65 - text-item: Generate text content for multi file messages

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading