Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • chatty chatty
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 288
    • Issues 288
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 14
    • Merge requests 14
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Librem5
  • chattychatty
  • Merge requests
  • !1068

mmsd: Fix total max attachment size

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Evangelos Ribeiro Tzaras requested to merge evangelos.tzaras/chatty:fix-max-attachment into master Mar 13, 2022
  • Overview 7
  • Commits 1
  • Pipelines 3
  • Changes 1

On amd64 and arm64 gsize is typedef'ed to unsigned long (64 bit wide). The "i" GVariant format string is for gint32 the g_variant_get() family of functions (g_variant_dict_lookup in this case).

Therefore we must initialize the gsize typed value to zero to make sure we don't end up with random memory in the upper bits.

Fixes 9c627f52

Closes #686 (closed)

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: fix-max-attachment