Skip to content

Add MMS Settings UI to Chatty

Chris Talbot requested to merge kop316/chatty:wip/mms_settings into master

cc @tobias.bernard @mohammed.sadiq

This adds UI settings for MMS in Chatty

Closes #559 (closed)

20210921_22h18m24s_grim

I did not address the following comments here: #559 (comment 171484)

The apply button should not be part of the listbox, but in the headerbar, together with a cancel button for discarding everything you changed on the view (like a regular action dialog).

I could not figure out how to do this, but I think this will just be an edit in src/ui/chatty-settings-dialog.ui.

In this new context where they're inline I think what you have on the screenshot is ok, but I'd make the entries wider by 50px or so, so there's not as much whitespace on the left.

I could not figure out how to do this (I added <property name="hexpand">True</property> to the GtkEntry, but that makes them look misaligned). I think this will just be an edit in src/ui/chatty-settings-dialog.ui.

Additionally, to address #559 (comment 170069) :

I am working on an mmsd branch to add support for it to automatically add the appropriate provider info here: https://gitlab.com/kop316/mmsd/-/tree/wip/provider_info

Edited by Chris Talbot

Merge request reports