If we fail to create the file monitor for the user JS file, then we free
the error twice by mistake. Uh-oh. Found by Coverity.

This reverts commit b37ef802.

Looks like we were too aggressive here. WebKit's default behavior may
not actually be suitable for browsers. It broke the VMWare vSphere web
console.

Fixes #1467

This was rejected from WebKit in
https://bugs.webkit.org/show_bug.cgi?id=220512.

Fixes: https://gitlab.gnome.org/GNOME/epiphany/-/issues/802

This was added in
https://gitlab.gnome.org/GNOME/epiphany/-/commit/cba76bc107e26de853571fde16b240f88dd3d8b6.

It's no longer needed with the version of WebKitGTK we already require
(2.29.3) so we can remove it.

This will block access to cookies, localStorage, and IndexedDB. That is,
it will finally do what users who previously disabled cookies *actually*
wanted to do.

This is our replacement for the previous tri-state cookie policy, which
no longer makes sense now that we have ITP.

If the user is updating Epiphany ahead of WebKit... well, they probably
have hundreds of unfixed CVEs, so no need to worry about them losing
WebAudio or WebGL.

Having a separate cookie storage preference doesn't make a lot of sense
anymore now that we have ITP. See:
https://gitlab.gnome.org/GNOME/epiphany/-/merge_requests/713#note_844468

Our default setting (no third-party) does not work anymore since:
https://bugs.webkit.org/show_bug.cgi?id=213502

Also, users who disable cookie storage entirely are probably not
achieving their desired behavior, since we still allow storing
other forms of website data like localstorage or IndexedDB, unlike
Safari which blocks website data storage when cookies are disabled.

A new option to disable all local website data storage will follow in a
subsequent commit.

Michael Catanzaro authored 4 years ago and Jan-Michael Brummer committed 4 years ago

There's a bunch of unused code here designed to prevent this function
from doing anything if called for a non-Epiphany settings schema, but
this never happens. Maybe in the past it was hooked up to watch for
changes to system settings, but if so, that was probably long, long ago.

Also, default font size should be 12.

Incredibly, we were accidentally ignoring system font settings for serif
fonts if custom fonts were ever enabled in the past.

Fixes #1231

Fixes: https://gitlab.gnome.org/GNOME/epiphany/-/issues/298

This is recommended to prevent phishing attacks, see

  https://blog.mozilla.org/security/2017/11/27/blocking-top-level-navigations-data-urls-firefox-59/

WebKitGTK has introduced a WebKitSettings.allow-top-navigation-to-data-urls
property which can be used for this when set to FALSE. While trunk already
uses that default, in WebKitGTK 2.28 this defaults to TRUE and needs to be
explicitly set.

The style sheet monitoring code doesn't seem to be prepared for the user
to remove the user style. When the style is removed, we should stop
monitoring the file and un-apply the style on all views.

Also, there is a refcounting error in user_style_sheet_read_cb():
output_stream is unreffed immediately after starting an async function
call, but it needs to be kept alive until after the call is completed.
This is bad because it could cause crashes.

Finally, and of least importance, webkit_pref_callback_user_stylesheet()
is currently designed to assert if called to enable the setting twice in
a row. Although that should probably never happen -- if the setting is
currently enabled, then if changed it should be switched to disabled,
not called again to enable -- it's simple to rearraneg the code to be
robust to this possibility.

Noticed in #1026.

Michael Catanzaro authored 5 years ago and Jan-Michael Brummer committed 5 years ago

Die, NPAPI! Die!

Michael Catanzaro authored 5 years ago and Jan-Michael Brummer committed 5 years ago

These are weird settings. Epiphany doesn't let the user decide whether
to enable other WebKit-level features, except when it actually makes
sense to offer the user a choice of whether or not to do so. But letting
the user decide to break the web by disabling WebAudio or WebGL doesn't
make any sense. So remove these hidden settings.

Also, don't manually enable settings that are already enabled by default
in WebKitSettings.

This reverts commit c398d645.

Many complaints about the new behavior from Igalia developers. See #181.

Fixes: https://gitlab.gnome.org/GNOME/epiphany/issues/181

This allows to use a mobile user agent.

WebKit 2.23.90 has a built-in gesture for back/forward navigation, so
enable it.

This just more accurately reflects what it actually is.

Michael Catanzaro authored 6 years ago and Jan-Michael Brummer committed 6 years ago

Accelerated compositing mode is required to achieve acceptable
performance on certain hardware that we care about, but also causes
unacceptable performance degredation on other hardware. It also
significantly increases memory usage requirements.

Let's allow the user to choose. Distributors can use a gsettings
override if needed to target particular hardware.

Default policy will be on-demand, at least for now. Might be revisited
again soon. Maybe very soon.

Michael Catanzaro authored 6 years ago and Jan-Michael Brummer committed 6 years ago

This reverts commit 23d6eb98.

We're going to try reenabling hardware acceleration and hope for the
best!

Fixes #595 (sort of)

Fixes: https://gitlab.gnome.org/GNOME/epiphany/issues/370

See #595

Other browsers don't do this and there's no clear reason to do so.

Related to: https://bugs.webkit.org/show_bug.cgi?id=191614

This is broken and not ready to be enabled, but we think YouTube has
begun to require MSE to access WebM videos. So we're left with no
real choice here.

This reverts commit c61da877.

Continuing to experiment with this setting....

This reverts commit 4df5b310.

Let's see what this breaks. I'm suspecting we'll be seeing fewer
complaints, rather than more.

This reverts commit d4a25d10.

Enabled by default, of course.

We might want to drop the vanilla third-party policy, but let's start
with this for now.

Concern: there's not currently any way to clear the resource load
statistics directory....

* Convert points to pixels with webkit_settings_font_size_to_pixels().
* Font size is adjusted automatically when GtkSettings:gtk-xft-dpi changes.