On some occasions, the user authenticates properly, but the session
startup fails for some reason (or there's a communication error leading
us to believe something went wrong). Both cases were handled the same
way, giving the user identical feedback in both cases, leading to
legitimate confusion.

Let's decouple authentication and session startup so we can handle both
cases appropriately.

Users are confused that they can swipe up on the default page but are
unable to login unless they actually click on the user button. Let's fix
this bad UX by creating the greetd session only by the time we changed
pages, and using the first username in the list (selected by default) as
the default value.

We can assume the user will generally want to use the same session.
Improve the UX by automatically selecting the last used session.

This commit adds the ability to save the session ID into a file every
time a session is successfully started. This file is read on startup so
this session can be selected by default.

Requirement: a `/var/lib/phog` folder must exist and be writeable by
whatever user `greetd` runs as.

There's no reason we should stick to wayland sessions only.

This will allow us to differentiate between wayland and X11 sessions.

This will get rid of some compilation warnings along the way.

A session's `.desktop` file might not contain the `DesktopNames` key,
leading to issues when retrieving this value for setting the
`XDG_CURRENT_DESKTOP` env var. Fix this problem by falling back to the
session ID if this parameter is missing.

It only contains the brightness scale which doesn't work yet (it needs
some more work to use logind's `SetBrightness()` D-Bus method), so don't
bother with it for now and hide the whole thing.

Phosh relies on gnome-session in order to perform those actions, which
is not running when using `phog`. Instead, re-enable the logind D-Bus
interface and use it to trigger reboot and power-off events.

This is unneeded as it's basically the same as `phosh`.

Arnaud Ferraris authored 2 years ago and Arnaud Ferraris committed 2 years ago

Distributors might want to customize a bit the user experience, so we
can add a `GtkImage` placeholder. If the file `/etc/phog/logo.png`
exists, then it is loaded to the `GtkImage` and appears at the bottom
of the display.

Note: this image should not exceed 240px wide!

Arnaud Ferraris authored 2 years ago and Arnaud Ferraris committed 2 years ago

Users with multiple environments installed will be able to easily switch
that way.

Note: only Wayland sessions are taken into account, and the selector is
only visible if there are at least 2 of those.

Arnaud Ferraris authored 2 years ago and Arnaud Ferraris committed 2 years ago

We move this logic from `PhogLockscreen` to `PhogGreetd` as it seems
better there (and will limit the size of `PhogLockscreen).

Arnaud Ferraris authored 2 years ago and Arnaud Ferraris committed 2 years ago

This should be a Debian-only thing, unneeded in upstream sources.

Arnaud Ferraris authored 2 years ago and Arnaud Ferraris committed 2 years ago

Sorry Guido! ;)

Document changes and release 0.21.1

See merge request World/Phosh/phosh!1153

Part-of: <https://gitlab.gnome.org/World/Phosh/phosh/-/merge_requests/1153>

screen-saver-manager: More cleanups

See merge request World/Phosh/phosh!1141

This was on the LockscreenManager before but for blanking
only we want it on the screensaver.

Signed-off-by: Guido Günther <guido.gunther@puri.sm>
Part-of: <https://gitlab.gnome.org/World/Phosh/phosh/-/merge_requests/1141>

Signed-off-by: Guido Günther <guido.gunther@puri.sm>
Part-of: <https://gitlab.gnome.org/World/Phosh/phosh/-/merge_requests/1141>

This avoids an odd singleton with an argument. Instead use our current
pattern to create the object in the shell and add an accessor.

Signed-off-by: Guido Günther <guido.gunther@puri.sm>
Part-of: <https://gitlab.gnome.org/World/Phosh/phosh/-/merge_requests/1141>

This is similar to

  5fdc75d1 ("screen-saver-manager: Shorten DBus names")

bug for the ScreenSaverIface we implement.

Signed-off-by: Guido Günther <guido.gunther@puri.sm>
Part-of: <https://gitlab.gnome.org/World/Phosh/phosh/-/merge_requests/1141>

ci: update cross image

See merge request World/Phosh/phosh!1151

This allows the i386 build to pass again

Signed-off-by: Guido Günther <guido.gunther@puri.sm>
Part-of: <https://gitlab.gnome.org/World/Phosh/phosh/-/merge_requests/1151>

shell: Tweak phosh_shell_set_state() debug message

See merge request World/Phosh/phosh!1147

before:
Adding to PHOSH_STATE_BLANKED shells state. New state: PHOSH_STATE_BLANKED | PHOSH_STATE_LOCKED
Removing from PHOSH_STATE_BLANKED shells state. New state: PHOSH_STATE_LOCKED

after:
Adding PHOSH_STATE_LOCKED to shells state. New state: PHOSH_STATE_LOCKED | PHOSH_STATE_OVERVIEW
Removing PHOSH_STATE_LOCKED from shells state. New state: PHOSH_STATE_OVERVIEW

Part-of: <https://gitlab.gnome.org/World/Phosh/phosh/-/merge_requests/1147>

style: Overview & appgrid fixes for high contrast

See merge request World/Phosh/phosh!1121

Part-of: <https://gitlab.gnome.org/World/Phosh/phosh/-/merge_requests/1121>

Fixes for glib 2.74

Closes #840 and #841

See merge request World/Phosh/phosh!1148

Fiona Klute authored 2 years ago and Guido Gunther committed 2 years ago

G_REGEX_JAVASCRIPT_COMPAT is unsupported as of glib 2.74 and
not needed for the regex at hand.

G_REGEX_DEFAULT is the preferable default but not available before
glib 2.73.2, so there's a fallback to 0 for earlier versions.

Closes: https://gitlab.gnome.org/World/Phosh/phosh/-/issues/840
Part-of: <https://gitlab.gnome.org/World/Phosh/phosh/-/merge_requests/1148>

Evangelos Ribeiro Tzaras authored 2 years ago and Guido Gunther committed 2 years ago

While it was always invalid it is enforced as of glib 2.74.

This fixes tests failing like:

GLib-ERROR **: 08:25:34.271: g_log_set_writer_func() called multiple times

Closes: https://gitlab.gnome.org/World/Phosh/phosh/-/issues/841
Part-of: <https://gitlab.gnome.org/World/Phosh/phosh/-/merge_requests/1148>