Fix crash exposed by glib 2.76 (!109) · Merge requests · Librem5 / feedbackd

Merged Guido Gunther requested to merge guido.gunther/feedbackd:fixes into main 2 years ago

Mar 13, 2023
- tests/profile: Don't leak json node · f9c65381
  Guido Gunther authored 2 years ago
  
  f9c65381
- feedback-theme: Don't leak parent name · 3d7c4b37
  Guido Gunther authored 2 years ago
  
  3d7c4b37
- feedback-theme: Don't leak json array when serializing profile · 7becab33
  Guido Gunther authored 2 years ago
  
  json_array_add_element doesn't transfer ownership.
  7becab33
- feedback-profile: Don't leak json array when serializing profile · 5206c3aa
  Guido Gunther authored 2 years ago
  
  json_array_add_element doesn't transfer ownership
  5206c3aa
- tests: Don't leak profiles and test that · 1933a231
  Guido Gunther authored 2 years ago
  
  We finalize the theme first so the last reference is dropped when finalizing the profiles.
  1933a231
- tests: Don't leak json string · 460985cf
  Guido Gunther authored 2 years ago
  
  460985cf
- fbd-event: Make sure we iterate the list safely · 03b0f4c2
  Guido Gunther authored 2 years ago
  
  When all feedbacks are done the event signals "feedbacks-ended" which lets the manager dispose the feedback. When all feedbacks end instantly and synchronously (as is the case with the dummy feedback) this triggers the disposal of the event within the loop leading to a crash. Make sure the object doesn't go away be referencing it during the loop iteration. We didn't see this before as glib's slice allocator for lists papered over this for us. Closes: #69
  03b0f4c2
- fbd-event: Simplify · 64076e5a
  Guido Gunther authored 2 years ago
  
  Gbp-Dch: Ignore
  64076e5a
- build: Avoid meson deprecation warning · 847c21d7
  Guido Gunther authored 2 years ago
  
  847c21d7

Admin message

Admin message

Fix crash exposed by glib 2.76

Merge request reports

Activity