feedback-led: Ensure flash LED is stopped when prefer-flash is false

Fixes: #82 (closed)

Dunno if this is the right way to solve it, I looked at this code for about 45 seconds before #yoloing this patch. It does fix the issue for me, though.

Signed-off-by: Sam Day me@samcday.com

src/fbd-feedback-led.c

@@ -168,7 +168,12 @@ color_string_to_color (const char *color, gboolean prefer_flash, FbdLedRgbColor
 static void
 on_prefer_flash_changed (FbdFeedbackLed *self)
 {
-  self->prefer_flash = g_settings_get_boolean (self->settings, "prefer-flash");
+  gboolean prefer_flash = g_settings_get_boolean (self->settings, "prefer-flash");
+
+  if (self->prefer_flash && !prefer_flash)
+    fbd_feedback_end (FBD_FEEDBACK_BASE (self));
+
+  self->prefer_flash = prefer_flash;
   g_debug ("Prefer flash: %d", self->prefer_flash);
 }