Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • feedbackd feedbackd
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 23
    • Issues 23
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 4
    • Merge requests 4
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

Due to an influx of spam, we have had to impose restrictions on new accounts. Please see this wiki page for instructions on how to get full permissions. Sorry for the inconvenience.

  • Librem5
  • feedbackdfeedbackd
  • Merge requests
  • !73

fbd: led: Make dimming optional

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Andreas Hartmann requested to merge hartan/feedbackd:feature/disable-dimming into master Apr 06, 2022
  • Overview 4
  • Commits 1
  • Pipelines 1
  • Changes 3

The pattern used for controlling the LEDs will apply dimming effects by default. This may be undesirable in certain circumstances.

Adds a new property to the configuration and LED struct that makes dimming a configurable option.

Relates to #53 (closed). I'm not adding this to work around the kernel-related issues I have, but I thought that it may be nice to have regardless. What is your opinion on this?

I already verified it works by injecting "dimming": false to the theme files on my pinephone.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: feature/disable-dimming