Skip to content
Snippets Groups Projects

USB gadget: Drop g_multi in favor of librem5-base

All threads resolved!

Draft, because I can't get the .deb to build and test it properly.

Draft, because the MAC should be done as a systemd enviroment variable, to prevent resetting at every upgrade.

Draft, because it's based on !220 (merged)

Edited by Dorota Czaplejewicz

Merge request reports

Pipeline #70415 passed

Pipeline passed for 31a7aeba on dorota.czaplejewicz:gadget

Merged by Guido GuntherGuido Gunther 3 years ago (Aug 30, 2021 12:41pm UTC)

Merge details

  • Changes merged into with 31a7aeba.
  • Deleted the source branch.

Pipeline #70417 passed

Pipeline passed for 31a7aeba on pureos/byzantium

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    • 52fb7d02 - USB gadget: Drop g_multi in favor of gadgetfs

    Compare with previous version

  • This works well for me.

    USB ethernet nterfaces get a distinct name now.

  • Did you have a look at libusbgx/gt and gadget schemes?

  • Yes, I checked that those are not in Debian and decided to let someone else deal with it :)

  • added 1 commit

    • 4cdf5ad5 - USB gadget: Drop g_multi in favor of gadgetfs

    Compare with previous version

  • Updated check for mass_storage_dummy, plus added a knob to change the device-facing MAC address, since that's actually what is mapped to an IP address via DHCP.

  • Dorota Czaplejewicz marked this merge request as ready

    marked this merge request as ready

  • Dorota Czaplejewicz changed the description

    changed the description

  • Anyone willing to test and merge this? I just locked myself out of network access while testing another MR !222 (closed) and it made me sad :S

  • added 1 commit

    • a48f640a - USB gadget: Drop g_multi in favor of gadgetfs

    Compare with previous version

  • Please move that from librem5-devkit-tools to librem5-base while reworking this. As noted elsewhere we don't want to add any non-devkit specific stuff to librem5-devkit-base so it can get removed eventually on the l5.

  • added 8 commits

    Compare with previous version

  • Dorota Czaplejewicz changed title from USB gadget: Drop g_multi in favor of gadgetfs to USB gadget: Drop g_multi in favor of librem5-base

    changed title from USB gadget: Drop g_multi in favor of gadgetfs to USB gadget: Drop g_multi in favor of librem5-base

  • This MR now only removes gadget support. The re-adding is meant to be done in librem5-base.

    Edited by Dorota Czaplejewicz
  • mentioned in merge request librem5-base!255 (merged)

  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Guido Gunther added 3 commits

    added 3 commits

    Compare with previous version

  • Guido Gunther resolved all threads

    resolved all threads

  • merged

  • Yay! Thanks. It's one of those small things that unblock bigger ones.

  • Please register or sign in to reply
    Loading