Skip to content
Snippets Groups Projects

xwayland: Automaximization support

All threads resolved!

WIP because:

  • it still needs to check the window type in order to not maximize things it shouldn't (like tooltips or menus)
  • there appears to be some race condition visible in Anbox that sometimes results in the window state being desynchronized between xwm and phoc (or at least I assume that's what happens there)
Edited by Sebastian Krzyszkowiak

Merge request reports

Pipeline #58956 passed

Pipeline passed for 03e2e2e9 on sebastian.krzyszkowiak:xwayland-maximization

Test coverage 41.60% (-0.20%) from 1 job

Merged by Guido GuntherGuido Gunther 4 years ago (Sep 18, 2020 4:46pm UTC)

Loading

Pipeline #58970 passed

Pipeline passed for 03e2e2e9 on master

Test coverage 41.60% (-0.20%) from 1 job

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Guido Gunther
  • Guido Gunther
  • Guido Gunther
  • Guido Gunther
  • Guido Gunther
  • Guido Gunther
  • Guido Gunther
  • Besides the above this looks good to me and handling all windows consistently sure is an improvement.

    Edited by Guido Gunther
  • added 4 commits

    • a72667c1 - xwayland: Don't apply size constraints to maximized windows
    • 3b18ddd8 - xwayland: Correctly handle windows that are maximized on map
    • 0ac3d997 - xwayland: Automaximization support
    • 369c2244 - seat: Check whether moving and resizing is allowed

    Compare with previous version

  • added 2 commits

    • 4e90d9ed - xwayland: Automaximization support
    • a2943fa1 - seat: Check whether moving and resizing is allowed

    Compare with previous version

  • Sebastian Krzyszkowiak resolved all threads

    resolved all threads

  • added 7 commits

    • a2943fa1...eec6a66a - 3 commits from branch Librem5:master
    • 8079bddf - xwayland: Don't apply size constraints to maximized windows
    • d921747e - xwayland: Correctly handle windows that are maximized on map
    • 1af06a94 - xwayland: Automaximization support
    • 49e5bcd1 - seat: Check whether moving and resizing is allowed

    Compare with previous version

  • looks good to me besides the above minor nit.

  • added 4 commits

    • 15dff45a - xwayland: Don't apply size constraints to maximized windows
    • 1fc8b5ec - xwayland: Correctly handle windows that are maximized on map
    • 85c20cd3 - xwayland: Automaximization support
    • 03e2e2e9 - seat: Check whether moving and resizing is allowed

    Compare with previous version

  • Sebastian Krzyszkowiak resolved all threads

    resolved all threads

  • merged

  • Please register or sign in to reply
    Loading