Skip to content

Shell manager: honor action shell modes

Evangelos Ribeiro Tzaras requested to merge (removed):shell_manager_honor_action_shell_modes into master

Aims to close #455 (closed)

Still WIP because I believe some discussion is probably needed around the different ShellActionModes.

  • SHELL_ACTION_MODE_OVERVIEW: Not entirely sure what's meant by "overview". My best guess is that this means the application overview/finder in GNOME in which case I would suggest mapping it to the folded state of PhoshHome
  • SHELL_ACTION_MODE_UNLOCK_SCREEN vs SHELL_ACTION_MODE_LOCK_SCREEN: I would not distinguish these two
  • SHELL_ACTION_MODE_LOGIN_SCREEN: not useful for us and I don't understand how this would work in GNOME since the shell should not be started while still on the login screen?
  • SHELL_ACTION_MODE_SYSTEM_MODAL: I guess this would be easier with #300 (closed) ?
  • SHELL_ACTION_MODE_LOOKING_GLASS: no idea if/how this relates to phosh
  • SHELL_ACTION_MODE_POPUP: no idea if/how this relates to phosh
Edited by Evangelos Ribeiro Tzaras

Merge request reports