Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • phosh phosh
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 124
    • Issues 124
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

Due to an influx of spam, we have had to impose restrictions on new accounts. Please see this wiki page for instructions on how to get full permissions. Sorry for the inconvenience.

  • Librem5
  • phoshphosh
  • Merge requests
  • !801

WIP: Allow to unfold keyboard to allow for non-numeric passwords

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Guido Gunther requested to merge guido.gunther/phosh:keypad into master Apr 27, 2021
  • Overview 0
  • Commits 3
  • Pipelines 2
  • Changes 8

Since this comes up ever so often this MR does:

  • add a keyboard button to the lock screen dial pad that unfolds the keyboard on press
  • allow arbitrary text input
  • hide keyboard when we time out and switch back to the lock screen

Design issues

  • does this fly at all?
  • should we hide the keypad with a revealer when the keyboard is folded out?
  • should the label change from passcode to passord ?

TODOs (mostly mechanical):

  • replace keypad-button by regular buttons
  • adjust d/copyright
  • add to docs
  • add keypad tests from libhandy too

/cc @tobias.bernard

Screenshot_from_2021-04-27_18-13-22 Screenshot_from_2021-04-27_18-13-32

Closes: #97

Edited Apr 29, 2021 by Guido Gunther
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: keypad