1. 03 Nov, 2005 3 commits
    • Tor Lillqvist's avatar
      Rename the variables for the color bitmap to have "color" in their name, · 5551fc67
      Tor Lillqvist authored
      2005-11-03  Tor Lillqvist  <tml@novell.com>
      
      	* gdk/win32/gdkcursor-win32.c (pixbuf_to_hbitmaps_alpha_winxp):
      	Rename the variables for the color bitmap to have "color" in their
      	name, for similarity with pixbuf_to_hbitmaps_normal(). Create a
      	color bitmap for the mask, too, instead of creating a b&w bitmap
      	with CreateBitmap(). Set up the mask bitmap's contents, ones for
      	those pixels in the color bitmap where the alpha is zero, zero for
      	other pixels. We used to use an unitialized mask bitmap! This
      	meant that icons and cursors created presumably worked more or
      	less by accident. Totally blank icons with zero alpha everywhere
      	(as used by gtktrayicon.c) definitely did not work as expected.
      5551fc67
    • Tor Lillqvist's avatar
      Include gtkstatusicon.c on all platforms. · 3d18823a
      Tor Lillqvist authored
      2005-11-03  Tor Lillqvist  <tml@novell.com>
      
      	* gtk/Makefile.am: Include gtkstatusicon.c on all platforms.
      
      	* gtk/gtkstatusicon.c: Implement for Win32. Use code from
      	gtktrayicon-win32.c as applicable. (gtktrayicon-win32.c is not
      	necessary and can be removed from CVS. It has never been mentioned
      	in gtk/Makefile.am.) No tray icon widget, GtkImage or GtkTooltips
      	are used on Win32. One label widget is used (but never shown) as
      	gtk_widget_render_icon() needs a widget.
      
      	Ifdefs used as necessary in several places. It might be cleaner to
      	split out the backend-specific parts to separate files, or at
      	least collect them into separate blocks in the file.
      
      	(wndproc): New function. Window procedure to monitor mouse events
      	in the system tray icon. Call gtk_status_icon_button_press() as
      	needed.
      	(create_tray_observer): New function. Creates a hidden window that
      	only serves as a tray icon message observer.
      3d18823a
    • Tor Lillqvist's avatar
      Position the dialog with GTK_WIN_POS_CENTER. (do_quit): New function, hide · 542aedc1
      Tor Lillqvist authored
      2005-11-03  Tor Lillqvist  <tml@novell.com>
      
      	* tests/teststatusicon.c (icon_activated): Position the dialog
      	with GTK_WIN_POS_CENTER.
      	(do_quit): New function, hide and unref the GtkStatusIcon, and
      	call gtk_main_quit().
      	(popup_menu): Add a Quit menu item that calls do_quit().
      542aedc1
  2. 02 Nov, 2005 3 commits
    • Tor Lillqvist's avatar
      gdk/win32/gdkcolor-win32.c gdk/win32/gdkscreen-win32.c Whitespace · c2c55f83
      Tor Lillqvist authored
      2005-11-02  Tor Lillqvist  <tml@novell.com>
      
      	* gdk/win32/gdkcolor-win32.c
      	* gdk/win32/gdkscreen-win32.c
      	* gdk/win32/gdkwindow-win32.c: Whitespace consistency
      	fixes. Remove superfluous test for GdkWindow* parameters being
      	non-NULL. Testing GDK_IS_WINDOW() is enough. As there is only one
      	GdkScreen and one GdkDisplay in the Win32 backend, use those
      	variables instead of the getter functions. For GdkDisplay* and
      	GdkScreen* parameters, check that they are equal to the
      	corresponding singleton variables instead of the more general
      	GDK_IS_DISPLAY() or GDK_IS_SCREEN().
      c2c55f83
    • Matthias Clasen's avatar
      Remove some g_return_if_fail() from static functions, replace some others · aa70008f
      Matthias Clasen authored
      2005-11-02  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtktextview.c: Remove some g_return_if_fail() from
      	static functions, replace some others by g_assert().
      
      	* gtk/gtktextview.c (selection_motion_event_handler)
      	(gtk_text_view_start_selection_drag): Keep track of the original
      	selection boundaries during a drag selection, in order to correctly
      	decide when to extend or shrink the selection.  (#320167,
      	reported by Arvind S N, patch by Paolo Borelli)
      aa70008f
    • Matthias Clasen's avatar
      Replace manual offset calculations by g_utf8_offset_to_pointer(). · 6002bc65
      Matthias Clasen authored
      2005-11-02  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtktextbtree.c (_gtk_text_line_char_to_byte_offsets):
      	* gtk/gtktextiter.c (gtk_text_iter_backward_chars): Replace
      	manual offset calculations by g_utf8_offset_to_pointer().
      	(#320360, Paolo Borelli)
      6002bc65
  3. 01 Nov, 2005 4 commits
    • Tim Janik's avatar
      get rid of GAllocator usage, allocate and free nodes via the g_slice_*() · d6a9db90
      Tim Janik authored
      Tue Nov  1 16:18:24 2005  Tim Janik  <timj@imendio.com>
      
              * gtk/gtkrbtree.[hc]: get rid of GAllocator usage, allocate and free
              nodes via the g_slice_*() API.
              _gtk_rbtree_new(): fixed wrong node allocation via g_new().
      d6a9db90
    • Tor Lillqvist's avatar
      gdk/win32/gdkprivate-win32.h gdk/win32/gdkglobals-win32.c Add more · 4d1b5589
      Tor Lillqvist authored
      2005-11-01  Tor Lillqvist  <tml@novell.com>
      
      	* gdk/win32/gdkprivate-win32.h
      	* gdk/win32/gdkglobals-win32.c
      	* gdk/win32/gdkmain-win32.c (_gdk_windowing_init): Add more
      	pre-interned GdkAtoms and pre-registered clipboard formats. Sort
      	their declarations, definitions and assignments into a more
      	logical and consistent order.
      
      	* gdk/win32/gdkmain-win32.c (_gdk_win32_cf_to_string): Include the
      	CF_ prefix for the predefined clipboard format names. Put quotes
      	around registered format names to distinguish them.
      
      	* gdk/win32/gdkproperty-win32.c (gdk_property_change): Return
      	immediately with a warning if the property type is STRING, TEXT,
      	COMPOUND_TEXT or SAVE_TARGETS, as these are X11-specific that we
      	should never pretend to handle on Win32. Handle only UTF8_STRING
      	here, other formats with delayed rendering. Use \uc1 instead of
      	\uc0 when generating Rich Text Format for easier testability on
      	XP, where WordPad misinterprets \uc0 encoded characters. Add more
      	GDK_NOTE debugging output for Clipboard operations.
      
      	* gdk/win32/gdkselection-win32.c: Debugging printout improvements.
      	(gdk_selection_convert): Don't pretent to handle STRING, just
      	UTF8_STRING. Streamline error handling, don't unnecessarily have a
      	GError which then isn't used for anything anyway if it gets set.
      	(gdk_win32_selection_add_targets): Skip also STRING, TEXT,
      	COMPOUND_TEXT and SAVE_TARGETS in addition to UTF8_STRING.
      4d1b5589
    • Tor Lillqvist's avatar
      Sync with what configure produces. · 77769e2e
      Tor Lillqvist authored
      2005-11-01  Tor Lillqvist  <tml@novell.com>
      
      	* config.h.win32.in: Sync with what configure produces.
      77769e2e
    • Tor Lillqvist's avatar
      Don't look for X_PACKAGES unless building for x11. (#313986, John · b3175d19
      Tor Lillqvist authored
      2005-11-01  Tor Lillqvist  <tml@novell.com>
      
      	* configure.in: Don't look for X_PACKAGES unless building for
      	x11. (#313986, John Ehresman)
      b3175d19
  4. 28 Oct, 2005 8 commits
  5. 27 Oct, 2005 5 commits
    • Michael Natterer's avatar
      Fix bug #319974: · 194e8daf
      Michael Natterer authored
      2005-10-26  Michael Natterer  <mitch@imendio.com>
      
      	Fix bug #319974:
      
      	* gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_set_property):
      	make sure that setting any of pixbuf/stock-id/icon-name resets the
      	others because they are mutually exclusive, and that unsetting any
      	of them only resets the pixbuf and nothing else. Also added
      	some missing g_object_notify().
      
      	(gtk_cell_renderer_pixbuf_get_property): simplified calls to
      	g_value_set_object().
      
      	(gtk_cell_renderer_pixbuf_create_stock_pixbuf)
      	(gtk_cell_renderer_pixbuf_create_named_icon_pixbuf): added
      	g_object_notify ("pixbuf").
      194e8daf
    • Matthias Clasen's avatar
      Be more careful about initializing cell_area. (#319382, Tommi Komulainen) · 18f32d04
      Matthias Clasen authored
      2005-10-27  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtktreeview.c (gtk_tree_view_button_press): Be more
      	careful about initializing cell_area.  (#319382, Tommi
      	Komulainen)
      18f32d04
    • Matthias Clasen's avatar
      Don't eat Ctrl-PageUp/PageDown. (#318670, Christian Neumair) · 7de0d972
      Matthias Clasen authored
      2005-10-27  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtkcombobox.c (gtk_combo_box_key_press): Don't eat
      	Ctrl-PageUp/PageDown.  (#318670, Christian Neumair)
      7de0d972
    • Matthias Clasen's avatar
      Only set the text if it is not NULL. (#319930, Thomas Klausner) · bc41f73c
      Matthias Clasen authored
      2005-10-27  Matthias Clasen  <mclasen@redhat.com>
      
      	* demos/gtk-demo/clipboard.c (paste_received): Only set the
      	text if it is not NULL.  (#319930, Thomas Klausner)
      
      	* gtk/gtkselection.c (gtk_selection_data_get_pixbuf): Close the
      	loader before trying to get the pixbuf.  (#319930, Thomas Klausner)
      bc41f73c
    • Matthias Clasen's avatar
      Use G_MODULE_BIND_LAZY when dlopening modules. (#319557, Laszlo Peter) · e80f12b6
      Matthias Clasen authored
      2005-10-26  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtkfilesystem.c (gtk_file_system_module_load):
      	* gtk/gtkthemes.c (gtk_theme_engine_load):
      	* gtk/gtkimmodule.c (gtk_im_module_load): Use G_MODULE_BIND_LAZY
      	when dlopening modules.  (#319557, Laszlo Peter)
      e80f12b6
  6. 26 Oct, 2005 9 commits
  7. 25 Oct, 2005 4 commits
    • Kristian Rietveld's avatar
      Fixes #311955, reported by Markku Vire; and a lot more. · af86cec5
      Kristian Rietveld authored
      2005-10-25  Kristian Rietveld  <kris@gtk.org>
      
      	Fixes #311955, reported by Markku Vire; and a lot more.
      
      	* gtk/gtktreemodelfilter.c: Made this thing work correctly.
      	Levels can now have invisible nodes cached, functions have been
      	rewritten/refactored to take this into account; also the logic in
      	some functions has been corrected.
      
      	Each referenced node now references all visible children or a single
      	invisible child, in order to be able to monitor all changes in the
      	child model required for correct operation.
      
      	When a virtual root is set, all nodes on the virtual root level are
      	referenced.
      
      	At last, a bunch of random bug fixes and comment updates.
      af86cec5
    • Matthias Clasen's avatar
      Add some more docs. (#319722, Paolo Borelli) · 86b656aa
      Matthias Clasen authored
      2005-10-25  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtktexttagtable.c (gtk_text_tag_table_foreach): Add some
      	more docs.  (#319722, Paolo Borelli)
      86b656aa
    • Matthias Clasen's avatar
      Make the initialization of screen_x11->xft_rgba more explicit. (#319627, · f10f8579
      Matthias Clasen authored
      2005-10-25  Matthias Clasen  <mclasen@redhat.com>
      
      	* gdk/x11/gdkxftdefaults.c (init_xft_settings): Make the
      	initialization of screen_x11->xft_rgba more explicit.  (#319627,
      	Bogdan Nicula)
      f10f8579
    • Matthias Clasen's avatar
      Fix whitespace in a blurb. (#319499, Francisco Javier F. Serrador) · d77bc26a
      Matthias Clasen authored
      2005-10-25  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtkfilechooser.c (gtk_file_chooser_class_init): Fix whitespace
      	in a blurb.  (#319499, Francisco Javier F. Serrador)
      d77bc26a
  8. 24 Oct, 2005 2 commits
    • Matthias Clasen's avatar
      Add settings to hide the input method and Unicode control character · f2724a25
      Matthias Clasen authored
      2005-10-24  Matthias Clasen  <mclasen@redhat.com>
      
              Add settings to hide the input method and Unicode control character
              submenus in the context menus of GtkEntry and GtkTextView.
      
              * gdk/x11/gdkevents-x11.c: Map GTK+ settings to X settings.
      
              * gtk/gtksettings.c (gtk_settings_class_init): Declare GTK+ settings here.
      
              * gtk/gtktextview.c (popup_targets_received):
              * gtk/gtkentry.c (popup_targets_received): Use the settings here.
      f2724a25
    • Kristian Rietveld's avatar
      emitting row-has-child-toggled when the level is not in the cache does not · 3fe6e986
      Kristian Rietveld authored
      2005-10-24  Kristian Rietveld  <kris@gtk.org>
      
      	* gtk/gtktreemodelsort.c (gtk_tree_model_sort_row_inserted): emitting
      	row-has-child-toggled when the level is not in the cache does not
      	make sense.  (This bug probably crept in during the early stages
      	of GtkTreeModelSort when there wasn't a correct row-has-child-toggled
      	implementation yet),
      	(gtk_tree_model_sort_real_unref_node): only get the child iter
      	when we will actually also use it.
      3fe6e986
  9. 22 Oct, 2005 2 commits
    • Michael Natterer's avatar
      check for the widget being realized, in addition to being visible, to · d25d6585
      Michael Natterer authored
      2005-10-22  Michael Natterer  <mitch@imendio.com>
      
      	* gtk/gtktreeview.c (gtk_tree_view_scroll_to_cell): check for the
      	widget being realized, in addition to being visible, to avoid
      	running into precondition check in gtk_tree_view_get_cell_area().
      	(approved by Kris).
      d25d6585
    • Dom Lachowicz's avatar
      Experimentally, scrollbar steppers can shrink to 8 pixels on Win32. · f9365c37
      Dom Lachowicz authored
      	* modules/engines/ms-windows/msw_style.c (setup_msw_rc_style):
      	Experimentally, scrollbar steppers can shrink to 8 pixels on
      	Win32. Reflect that in the theme.
      	* modules/engines/ms-windows/Theme/gtk-2.0/gtkrc: Experimentally,
      	there is a 1-pixel border between a scrollbar and its child
      	in ScrolledWindows on Win32. Reflect that in the theme.
      f9365c37