Skip to content
Snippets Groups Projects
  1. Oct 05, 2017
    • Eugen Rochko's avatar
      Implement hotkeys for web UI (#5164) · 7db0f8dc
      Eugen Rochko authored
      * Fix #2102 - Implement hotkeys
      
      Hotkeys on status list:
      
      - r to reply
      - m to mention author
      - f to favourite
      - b to boost
      - enter to open status
      - p to open author's profile
      - up or k to move up in the list
      - down or j to move down in the list
      - 1-9 to focus a status in one of the columns
      - n to focus the compose textarea
      - alt+n to start a brand new toot
      - backspace to navigate back
      
      * Add navigational hotkeys
      
      The key g followed by:
      
      - s: start
      - h: home
      - n: notifications
      - l: local timeline
      - t: federated timeline
      - f: favourites
      - u: own profile
      - p: pinned toots
      - b: blocked users
      - m: muted users
      
      * Add hotkey for focusing search, make escape un-focus compose/search
      
      * Fix focusing notifications column, fix hotkeys in compose textarea
      7db0f8dc
  2. Oct 03, 2017
  3. Oct 02, 2017
  4. Sep 30, 2017
  5. Sep 29, 2017
  6. Sep 28, 2017
    • Eugen Rochko's avatar
      Add ability to specify alternative text for media attachments (#5123) · 4ec17711
      Eugen Rochko authored
      * Fix #117 - Add ability to specify alternative text for media attachments
      
      - POST /api/v1/media accepts `description` straight away
      - PUT /api/v1/media/:id to update `description` (only for unattached ones)
      - Serialized as `name` of Document object in ActivityPub
      - Uploads form adjusted for better performance and description input
      
      * Add tests
      
      * Change undo button blend mode to difference
      4ec17711
  7. Sep 25, 2017
  8. Sep 24, 2017
  9. Sep 23, 2017
  10. Sep 22, 2017
  11. Sep 20, 2017
    • aschmitz's avatar
      Change IDs to strings rather than numbers in API JSON output (#5019) · 669fe9ee
      aschmitz authored
      * Fix JavaScript interface with long IDs
      
      Somewhat predictably, the JS interface handled IDs as numbers, which in
      JS are IEEE double-precision floats. This loses some precision when
      working with numbers as large as those generated by the new ID scheme,
      so we instead handle them here as strings. This is relatively simple,
      and doesn't appear to have caused any problems, but should definitely
      be tested more thoroughly than the built-in tests. Several days of use
      appear to support this working properly.
      
      BREAKING CHANGE:
      
      The major(!) change here is that IDs are now returned as strings by the
      REST endpoints, rather than as integers. In practice, relatively few
      changes were required to make the existing JS UI work with this change,
      but it will likely hit API clients pretty hard: it's an entirely
      different type to consume. (The one API client I tested, Tusky, handles
      this with no problems, however.)
      
      Twitter ran into this issue when introducing Snowflake IDs, and decided
      to instead introduce an `id_str` field in JSON responses. I have opted
      to *not* do that, and instead force all IDs to 64-bit integers
      represented by strings in one go. (I believe Twitter exacerbated their
      problem by rolling out the changes three times: once for statuses, once
      for DMs, and once for user IDs, as well as by leaving an integer ID
      value in JSON. As they said, "If you’re using the `id` field with JSON
      in a Javascript-related language, there is a very high likelihood that
      the integers will be silently munged by Javascript interpreters. In most
      cases, this will result in behavior such as being unable to load or
      delete a specific direct message, because the ID you're sending to the
      API is different than the actual identifier associated with the
      message." [1]) However, given that this is a significant change for API
      users, alternatives or a transition time may be appropriate.
      
      1: https://blog.twitter.com/developer/en_us/a/2011/direct-messages-going-snowflake-on-sep-30-2011.html
      
      * Additional fixes for stringified IDs in JSON
      
      These should be the last two. These were identified using eslint to try
      to identify any plain casts to JavaScript numbers. (Some such casts are
      legitimate, but these were not.)
      
      Adding the following to .eslintrc.yml will identify casts to numbers:
      
      ~~~
        no-restricted-syntax:
        - warn
        - selector: UnaryExpression[operator='+'] > :not(Literal)
          message: Avoid the use of unary +
        - selector: CallExpression[callee.name='Number']
          message: Casting with Number() may coerce string IDs to numbers
      ~~~
      
      The remaining three casts appear legitimate: two casts to array indices,
      one in a server to turn an environment variable into a number.
      
      * Back out RelationshipsController Change
      
      This was made to make a test a bit less flakey, but has nothing to
      do with this branch.
      
      * Change internal streaming payloads to stringified IDs as well
      
      Per
      https://github.com/tootsuite/mastodon/pull/5019#issuecomment-330736452
      we need these changes to send deleted status IDs as strings, not
      integers.
      669fe9ee
  12. Sep 16, 2017
  13. Sep 15, 2017
    • unarist's avatar
      Fix invisible load more button (#4962) · 6c81f9d6
      unarist authored
      * Fix behavior while the button is invisible
      e.g. pointer cursor, couldn't open contextmenu
      * Avoid rendering the button to remove blank space if no more items are available or no items are rendered
      6c81f9d6
  14. Sep 14, 2017
    • Eugen Rochko's avatar
      Redesign video player (#4911) · 2bbf987a
      Eugen Rochko authored
      * Redesign video player
      
      * Use new video player on static public pages too
      
      * Use media gallery component on static public pages too
      
      * Pause video when hiding it
      
      * Full-screen sizing on WebKit
      
      * Add aria labels to video player buttons
      
      * Display link card on public status page
      
      * Fix fullscreen from modal sizing issue
      
      * Remove contain: strict property to fix fullscreen from columns
      2bbf987a
  15. Sep 13, 2017
  16. Sep 09, 2017
  17. Sep 08, 2017
  18. Sep 07, 2017
  19. Sep 06, 2017
  20. Sep 02, 2017
  21. Sep 01, 2017
  22. Aug 31, 2017
  23. Aug 28, 2017
  24. Aug 24, 2017
  25. Aug 07, 2017
  26. Aug 04, 2017
  27. Aug 02, 2017
  28. Jul 30, 2017
    • Sorin Davidoi's avatar
      Improve accessibility (part 7) (#4457) · e44f03bc
      Sorin Davidoi authored
      * fix(media_modal): Keyboard navigation
      
      * fix(column_back_button): Use native button
      
      * fix(media_gallery): Keyboard navigation
      
      * fix(status_content): Make CW content focusable
      e44f03bc
Loading