Keyboard grab manager (volume and other media key)

This MR draws inspiration from !163 (closed) and is the first half of phosh#308 (closed)

It is related to phosh!537 (merged)

ToDos (from !163 (closed)):

• use input event keycodes
• support reporting modifiers
• allow the client to select the media keys it wants to watch
• use a separate interface

OSD, Mediakeys interface and the other DBus goodness which builds on top of this will be done in a separate MR for phosh!566 (merged).

mentioned in merge request phosh!537 (merged)

changed the description

mentioned in merge request !167 (merged)

i've split out the format changes into !167 (merged) so this becomes easier to look at in the web ui.

added 2 commits

• 5a0355ad - bump protocol version to 5
• 7c9c642e - get rid of phosh_forward_keysym, implement subscription handler

Compare with previous version

resolved all threads

added 7 commits

• 7c9c642e...c1c7ebf7 - 2 commits from branch Librem5:master
• 69850ace - phosh: Allow to forward volume key keysyms to client
• 8ef13f03 - First draft of keyboard_event interface
• 9858f61a - preparation for GrabManager
• 71410483 - bump protocol version to 5
• a2fbd695 - get rid of phosh_forward_keysym, implement subscription handler

Compare with previous version

added 1 commit

• 69a4c014 - use correct resource

Compare with previous version

added 1 commit

• 92aafba1 - hacky keyforward (similar to guidos version)

Compare with previous version

added 9 commits

• 92aafba1...d3d1eb8f - 2 commits from branch Librem5:master
• 0c51c604 - phosh: Allow to forward volume key keysyms to client
• 5b0986d0 - First draft of keyboard_event interface
• ffb9eaed - preparation for GrabManager
• 017b9313 - bump protocol version to 5
• 7ac8b2dd - get rid of phosh_forward_keysym, implement subscription handler
• 46fd4f7f - use correct resource
• 01da36b6 - hacky keyforward (similar to guidos version)

Compare with previous version

added 1 commit

• 160973b1 - some more implementation work

Compare with previous version

added 11 commits

• 160973b1...cfc76a12 - 2 commits from branch Librem5:master
• 4155782f - phosh: Allow to forward volume key keysyms to client
• f3c05555 - First draft of keyboard_event interface
• d6251ddf - preparation for GrabManager
• 9aa92367 - bump protocol version to 5
• 5c074f38 - get rid of phosh_forward_keysym, implement subscription handler
• 476535d8 - use correct resource
• cf6facc2 - hacky keyforward (similar to guidos version)
• af1f8d65 - some more implementation work
• 2a87a66d - actually set the keysym on subscribing

Compare with previous version

changed the description

added 1 commit

• ca6da9d7 - working as expected

Compare with previous version

added 1 commit

• e005f1f7 - Update keyboard_events interface

Compare with previous version

marked the checklist item use input event keycodes as completed

marked the checklist item support reporting modifiers as completed

marked the checklist item allow the client to select the media keys it wants to watch (we want to proxy in phosh to org.gnome.Shell.GrabAccelerators later on (phosh#98 (closed)) as completed

i think this moves the right way!

changed the description

added 1 commit

• e45a662f - Only allow keysym subscription for "subscribeable keysyms"

Compare with previous version

added 1 commit

• 75813319 - Complete keyboard_events interface description

Compare with previous version

added 2 commits

• bd381f6a - Implement keyforwarding with a new interface in phosh-private protocol
• 70a5ce2d - cleanup

Compare with previous version

added 5 commits

• 70a5ce2d...f3c17d9e - 4 commits from branch Librem5:master
• 3cd485d2 - Implement keyforwarding with a new interface in phosh-private protocol

Compare with previous version

added 1 commit

• 8e935d1b - Cleanup wl_list (keyboard_event)

Compare with previous version

Not quite sure why https://source.puri.sm/devrtz/phoc/-/jobs/281228 fails. Maybe doing the cleanup as in 8e935d1b is not the way to go?

unmarked as a Work In Progress

changed the description

added 1 commit

• 9f69331c - Implement keyforwarding with a new interface in phosh-private protocol

Compare with previous version

added 1 commit

• 4593ffa5 - Use GArray instead of wl_list

Compare with previous version

added 1 commit

• 2573c434 - Use GArray instead of wl_list

Compare with previous version

Quick question: At which point would the destroy function which is set via wl_resource_set_implementation be called? https://source.puri.sm/devrtz/phoc/-/blob/keyboard-events/src/phosh.c#L242 Can I call it explicitly? Will it be called implicitly somehow? I'm asking because I'm not 100% sure how to do the cleanup properly. See https://source.puri.sm/devrtz/phoc/-/blob/keyboard-events/src/phosh.c#L445

resolved all threads

changed the description

added 3 commits

• 2573c434...9db382eb - 2 commits from branch Librem5:master
• 3030b97b - Implement keyforwarding with a new interface in phosh-private protocol

Compare with previous version

resolved all threads

changed the description

i think this is moving the right way. Maybe @sebastian.krzyszkowiak has some comments otherwise we can merge this after some bikeshedding.

added 4 commits

• 13bfba69 - protocol interface descriptions
• aaf302ff - switch to GList
• 05f791c4 - indentation
• 8eb134f7 - post error for unsubscribeable keysyms

Compare with previous version